After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792912 - Alt+F mnemonic conflicts: File vs. Find
Alt+F mnemonic conflicts: File vs. Find
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Keybindings
git master
Other Linux
: Normal minor
: gnome-3-28
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-25 22:10 UTC by Egmont Koblinger
Modified: 2018-01-29 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (1.15 KB, patch)
2018-01-29 21:43 UTC, Egmont Koblinger 		none Details | Review
Fix, v2 (1.62 KB, patch)
2018-01-29 21:53 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2018-01-25 22:10:51 UTC 
Both the File and Find main menus have Alt+F as their mnemonics.

How to resolve? Alt+I for F_ind? Or revert to call it "Search"?
Comment 1 Egmont Koblinger 2018-01-29 21:02:49 UTC 
Christian, cast a vote please :) We should fix this before the UI freeze. I'm happy to do it.

The menu entry was renamed as per bug 757545 comment 2, but it could have just as well been renamed in the Shortcuts dialog.

I cast a weak vote for renaming back to Search. This way there's fewer non-initial mnemonics in the menu, the UI is more similar to the previous version's, users don't have to get used to something new that didn't bring any benefit, screenshot of the help and the help pages themselves (incl. translations) don't have to be changed here either.
Comment 2 Egmont Koblinger 2018-01-29 21:08:52 UTC 
gedit also has a Search menu.

(I especially love how both Firefox and Chrome have this standard File Edit View ... menubar, and there's Edit -> Find, like, wtf am I editing on the page when searching for a string?? I'm viewing it, dammit!)
Comment 3 Christian Persch 2018-01-29 21:14:55 UTC 
Ok, let's rename back to Search then.
Comment 4 Egmont Koblinger 2018-01-29 21:43:22 UTC 
Created attachment 367608 [details] [review]
Fix

As easy as this, I guess.

(Plus revert the relevant bits from the pending help page updates.)
Comment 5 Egmont Koblinger 2018-01-29 21:44:17 UTC 
Let me know if you'd prefer to rename some variables, too.
Comment 6 Egmont Koblinger 2018-01-29 21:53:56 UTC 
Created attachment 367611 [details] [review]
Fix, v2

Commenting too fast, sorry.

This is the only variable name that seems to be relevant, let's rename it too for consistency.