After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792026 - UI for setting contacts as favorite
UI for setting contacts as favorite
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-28 20:19 UTC by Niels De Graef
Modified: 2018-01-21 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Niels De Graef 2017-12-28 20:19:38 UTC 
I like to set some contacts as "favorite" in Google Contacts, as it makes them show up at the top (both in the Web UI, as on my phone for quick access). It would be really useful if this could be provided by GNOME contacts as well. I wouldn't mind implementing this, but I'd like to get some feedback first on the possible design.

So this bug is twofold:
1) Whether we should show favourites at the top. This can somewhat be related to bug 734720 (showing the user's own contact at the top).

2) What kind of UI do we use for this? Possible suggestions:
* A button in the headerbar
* Show a button in the list pane, e.g. on hover (this might clash with the checkbuttons)
* Show a button in the corner of the contact editor
* Show a button in the action bar
* ...
Comment 1 Niels De Graef 2017-12-28 20:21:39 UTC 
CC'ing Allan, my go-to contact (bad pun intended) for design issues.
Comment 2 Allan Day 2018-01-03 16:45:21 UTC 
(In reply to Niels De Graef from comment #0)
> I like to set some contacts as "favorite" in Google Contacts, as it makes
> them show up at the top (both in the Web UI, as on my phone for quick
> access). It would be really useful if this could be provided by GNOME
> contacts as well.

Sounds like a good idea!

> So this bug is twofold:
> 1) Whether we should show favourites at the top. This can somewhat be
> related to bug 734720 (showing the user's own contact at the top).

That could work, but you'd need to communicate why some contacts are at the top, probably with a "favorites" heading and then a "all contacts" heading below it.

An alternative would be to change the "All Contacts" heading to a pair of linked toggle buttons: "All" / "Favorites".
 
> 2) What kind of UI do we use for this? Possible suggestions:
> * A button in the headerbar

I think this would be my preference. It's what we do in the other apps (see Photos, for example). It also means that you don't have to dig for the action - it's right there.
Comment 3 Niels De Graef 2018-01-18 21:57:20 UTC 
Showing contacts separately at the top is now implemented on master (commit 83e6b54).

We still need to have a button to (un)set a contact as favorite though.
Comment 4 Niels De Graef 2018-01-21 18:02:20 UTC 
This has been landed as of commit 6d0b512 on master