GNOME Bugzilla – Bug 791361
Allow to go back to playlist via mouse click from album view
Last modified: 2017-12-19 11:08:08 UTC
Created attachment 365212 [details] [review] moidif on window.py Backbutton with mouse when we are on album to back to playlist . ( gamers mouse )
What is "moidif"? What is not working with "backbutton mouse from album"? What is this ticket about?
Hello Is not really a bug , is a extension for the page Album like the Alt+Left. With this patch we can back with a clic (gamers mouse)
Review of attachment 365212 [details] [review]: Your commit message is lacking (see https://wiki.gnome.org/Git/CommitMessages). libgd should not be part of your patch. My main problem here is the specific mapping of button 8. Why this button? What button is it exactly? Seems rather device/user specific. I'm not sure we can accept this. ::: gnomemusic/window.py @@ +323,3 @@ self._key_press_event_id = self.connect('key_press_event', self._on_key_press) + + self.button_press_event_id = self.connect('button_press_event', self.button_press) This var should be internal (prepend with _), but is unused anyway. @@ +401,3 @@ @log + + def button_press(self,widget,event): This function should be internal (prepend with _). @@ +404,3 @@ + #Go Back from Album with mouse button + if (event.button == 8): + if (self.toolbar._state != ToolbarState.MAIN): This can be one conditional (if x AND y).
*** This bug has been marked as a duplicate of bug 771934 ***