After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771934 - Back mouse button to navigate backwards
Back mouse button to navigate backwards
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 791361 (view as bug list)
Depends on: 777238
Blocks:
 
 
Reported: 2016-09-25 12:07 UTC by Alexandre Franke
Modified: 2017-12-19 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Back mouse button to navigate backwards (1.19 KB, patch)
2017-01-11 10:41 UTC, Abhinav Singh
none Details | Review
Enable Back mouse button to navigate backwards (1.18 KB, patch)
2017-01-13 22:42 UTC, Abhinav Singh
accepted-commit_now Details | Review

Description Alexandre Franke 2016-09-25 12:07:07 UTC
Mouse button 8 ("backward navigation") should have the same effect as clicking the back button in the top left corner, like it does in Software, Documents, Settings.
Comment 1 Marinus Schraal 2016-10-11 06:45:02 UTC
Patch welcome.
Comment 2 Alexandre Franke 2016-10-11 07:23:03 UTC
As a hint, this is how this was just done in GNOME Clocks (in Vala): https://git.gnome.org/browse/gnome-clocks/commit/?id=09988198a8a95ebe7c9a8ebd4d9aed1c7af976d6
Comment 3 Neel Chauhan 2016-10-11 20:41:24 UTC
I don't have a patch yet, but am interested in contributing one.
Comment 4 Neel Chauhan 2016-10-12 00:13:25 UTC
Never mind. I don't have a mouse with "Mouse button 8".
Comment 5 Abhinav Singh 2017-01-11 10:41:00 UTC
Created attachment 343292 [details] [review]
Back mouse button to navigate backwards

Creates the same effect as having pressed "Alt - F" combination.
Overridden button_release_event to handle mouse button 8.
Comment 6 Abhinav Singh 2017-01-13 22:42:04 UTC
Created attachment 343459 [details] [review]
Enable Back mouse button to navigate backwards

Creates the same effect as having pressed "Alt - Left" combination.
Overridden button_release_event to handle mouse button 8.

https://bugzilla.gnome.org/show_bug.cgi?id=777238
------
Behaviour of back ui button and short cut <ALT> + Left is not same. 
------
According to this link, also matched the behaviours for navigating back.

Note: This patch will only work if the patch from the above linked bug is applied.
Comment 7 Marinus Schraal 2017-12-19 11:08:08 UTC
*** Bug 791361 has been marked as a duplicate of this bug. ***
Comment 8 Marinus Schraal 2017-12-19 12:07:46 UTC
Review of attachment 343459 [details] [review]:

lgtm

::: gnomemusic/window.py
@@ +506,3 @@
     @log
+    def do_button_release_event(self, event):
+        explicit, code = event.get_button()

__ for unused var
Comment 9 Marinus Schraal 2017-12-19 12:55:17 UTC
The back button behaviour can still be erratic, but at least it should be consistently so ;)

Added this in commit e8b554ced46363978f3ef66158273efe5ddc1843 , thanks for the patches. Apologies for the delay.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.