After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791317 - GWeatherLocation: Remove _get_world_for_path() API
GWeatherLocation: Remove _get_world_for_path() API
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-06 19:08 UTC by Bastien Nocera
Modified: 2017-12-07 00:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GWeatherLocation: Remove _get_world_for_path() API (4.94 KB, patch)
2017-12-06 19:08 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-12-06 19:08:20 UTC 
As mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=791289#c7
Comment 1 Bastien Nocera 2017-12-06 19:08:26 UTC 
Created attachment 365143 [details] [review]
GWeatherLocation: Remove _get_world_for_path() API

And the changes it required from commit ad604b79. There are a number
of internal uses of gweather_location_get_world(), including in the
GWeatherTimezone code, and adding new API for the sake of our tests
feels wrong, and would complicate the public API for no reason.

Instead, allow using the LIBGWEATHER_LOCATIONS_PATH envvar to override
the location of the Locations.xml file. This makes it easy to use the
same API in our tests and installed.
Comment 2 Bastien Nocera 2017-12-07 00:30:22 UTC 
Attachment 365143 [details] pushed as d8e6152 - GWeatherLocation: Remove _get_world_for_path() API