Created attachment 365077 [details] [review]
GWeatherLocation: Add API to create world from specific path

This will be used to run tests from the uninstalled Locations.xml file.

Note that this also removes a guard from gweather_location_unref() so
that the created world can be destroyed (muhahaha).

Created attachment 365078 [details] [review]
tests: Add test for named-timezones codes

This is the first automated test for libgweather, so it is named
generically to be extended.

Review of attachment 365077 [details] [review]:

Looks good.

Review of attachment 365078 [details] [review]:

::: libgweather/test_libgweather.c
@@ +1,2 @@
+/* Small test app for disc concent detection
+ * (c) 2004 Ronald Bultje <rbultje@ronald.bitfreak.net>

???

Created attachment 365103 [details] [review]
tests: Add test for named-timezones codes

This is the first automated test for libgweather, so it is named
generically to be extended.

Attachment 365077 [details] pushed as ad604b7 - GWeatherLocation: Add API to create world from specific path
Attachment 365103 [details] pushed as 2373f56 - tests: Add test for named-timezones codes

(In reply to Bastien Nocera from comment #1)
> Created attachment 365077 [details] [review] [review]
> GWeatherLocation: Add API to create world from specific path
> 
> This will be used to run tests from the uninstalled Locations.xml file.
> 
> Note that this also removes a guard from gweather_location_unref() so
> that the created world can be destroyed (muhahaha).

I actually don't like this, as we have a bunch of difficult to work-around uses of gweather_location_get_world(), in gweather-location-entry.c, gweather-timezone-menu.c and gweather-timezone.c

I'll file a new bug about using an envvar instead.