After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790618 - Annotation button does not stay selected
Annotation button does not stay selected
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: pdf annotations
3.26.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 789888 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-11-20 13:17 UTC by Vitor
Modified: 2018-05-22 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not cancel annotation mode after highlighting (2.88 KB, patch)
2018-01-23 21:43 UTC, Jan Tojnar
none Details | Review

Description Vitor 2017-11-20 13:17:15 UTC
The annotation button has to be pressed for each new annotation. The button does not stay selected so a new annotation can be created with a new click of the mouse on another place of the document. 

I don't know if this is a bug, but it really bugs me (kkkk).

Users generally make more than one annotation to a text, especially if it is a long document and they are reading through it and making comments. 

The "Highlight" button has the same problem.

PC specs.:
Ubuntu 16.04 LTS
Dell Inspirion 5558
4GB Ram
i7 5500U CPU

Thanks for the support.
Comment 1 André Klapper 2017-11-21 14:25:46 UTC
Thanks for taking the time to report this.
However, you are using a version that is too old and not supported anymore by GNOME developers. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes by GNOME developers for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME.

Please check if the problem still occurs with a recent version of GNOME (3.26 or 3.24) and leave a comment here.

You are also free to report this bug in the bug tracking system of your Linux distribution if your distribution still supports your version 3.18.
Comment 2 Germán Poo-Caamaño 2017-11-21 15:07:38 UTC
The behaviour of annotations has not changed in a while. Of theses bug about the interaction with annotations are still valid.
Comment 3 Nelson Benitez 2017-11-22 14:41:55 UTC
I think the solution would be to add "add annotation" item to right click menu when Evince is in "Annotate document" mode (ie. when buttons for 'add annotation' are shown). What do you think?
Comment 4 Germán Poo-Caamaño 2017-11-22 15:28:53 UTC
(In reply to Nelson Benitez from comment #3)
> I think the solution would be to add "add annotation" item to right click
> menu when Evince is in "Annotate document" mode (ie. when buttons for 'add
> annotation' are shown). What do you think?

I think you are referring to a Bug 763943 ;-)

Mac Preview has a nice way to handle the annotations in the toolbar.
It has a button next to a drop down list. Something like the following ascii art:

+--------+-----+
|        |     |
|        |  |  |
|        |  V  |
+--------+-----+

The drop down list enables the user to select with annotation to work with, which updates the button on its left. The button on the left can be kept selected to work continuously on that annotation, or to push it again to stop annotating.

This approach seems quite convenient, and it can save an extra toolbar. However, it would make the HeaderBar even more crowded than currently is. See Bug 732289

Nevertheless, what I say here has nothing against solving Bug 763943
Because selecting the text and annotate it seems good, too.
Comment 5 Vitor 2017-11-23 12:36:57 UTC
Another idea is to enable continuous annotations  it via Keyboard Shortcut.

No menu entry needed if their is a shortcut. (although new users might need a menu entry to discover the feature. At least thats how I discover most program features kkk)

Thanks.
Comment 6 Germán Poo-Caamaño 2017-12-05 17:12:24 UTC
*** Bug 789888 has been marked as a duplicate of this bug. ***
Comment 7 Jan Tojnar 2018-01-23 21:43:36 UTC
Created attachment 367342 [details] [review]
Do not cancel annotation mode after highlighting

Previously, if user wanted to highlight multiple text segments,
she needed to press the highlight button before each highlighting.

This commit keeps the annotation mode enabled until user cancels it
manually, allowing a better highlighting flow.

https://bugzilla.gnome.org/show_bug.cgi?id=789888
Comment 8 GNOME Infrastructure Team 2018-05-22 17:28:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/862.