GNOME Bugzilla – Bug 790491
tidy up blacklisting and blacklist V4L2
Last modified: 2017-11-20 11:10:23 UTC
Blacklisting by GstPluginFeature means we need to "chase" different codec names as new codecs are added to vaapi, element names change in different releases, etc, and makes it inpractical to blacklist plugins with variable element names - eg the available video4linux2 m2m decoder blocks are dynamically probed and discovered at runtime. Switching the blacklist to disable entire plugins at a time makes the code simpler and easier to maintain, and allows us to blacklist V4L2 where using the HW decoder for thumbnailing blocks hardware resources and can prevent the user from getting HW decode if they are trying to play a video while thumbnailing is going on in the background.
Created attachment 363913 [details] [review] thumbnailer: blacklist GStreamer plugins rather than features This avoids the need to check multiple entries and changing feature names in upstream GStreamer.
Created attachment 363914 [details] [review] thumbnailer: blacklist video4linux2 plugin On most V4L2 platforms supported by GStreamer, there are a finite number of M2M decoders and if the thumbnailer is using them, it prevents the user from playing back their real video.
(See bug #790457 for the same change in Tracker.)
Both look good, thanks. Use upper case after the colon in the commit subject though.
Done, merged!