GNOME Bugzilla – Bug 790457
extract/gstreamer: blacklist video4linux2 GStreamer plugin
Last modified: 2017-11-17 14:56:31 UTC
Tweak the blacklisting code in the GStreamer extractor to match the blacklisted elememts by plugin, and then blacklist video4linux2 so the extractor won't consume V4L2 decode units and block real playback. It's not posible to match V4L2 by feature as they are dynamically generated based on available units, and this simplifies maintenance of the other blacklists for similar reasons.
Created attachment 363856 [details] [review] extract/gstreamer: blacklist via plugin rather than feature Using a features-based blacklist means that you need to keep adding new blacklist entries when new codecs are added, and makes it impossible to match plugins which generate features dynamically based on detected hardware.
Created attachment 363857 [details] [review] extract/gstreamer: blacklist video4linux2 plugin Avoid attempting to use V4L2 hardware-accelerated decoders, which can keep scarce hardware units busy and prevent user-facing applications from using hardware accelerated decode.
(fwiw I'll also submit the same change to the same blacklisting code in Totem!)
Review of attachment 363856 [details] [review]: Assuming bcmdec is still blacklisted as the module name matches, seems more correct and cleaner, nice :)
Review of attachment 363857 [details] [review]: Makes sense.
I checked both vaapi and bcmdec are registered with those plugin names, and the blacklisting certainly works for v4l2 as I was testing this all on an ARM box (how I found the seccomp snafu!).
Pushed.