After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790370 - The machine's name gets stripped when sent to sync headquarters!
The machine's name gets stripped when sent to sync headquarters!
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Sync
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-15 12:37 UTC by Dan Jacobson
Modified: 2017-11-27 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sync: Fix incorrect device name on accounts.firefox.com (38.46 KB, patch)
2017-11-26 00:36 UTC, Gabriel Ivașcu
none Details | Review
sync: Fix incorrect device name on accounts.firefox.com (38.45 KB, patch)
2017-11-26 00:41 UTC, Gabriel Ivașcu
committed Details | Review

Description Dan Jacobson 2017-11-15 12:37:04 UTC
One gets email:

New sign-in to Firefox
Epiphany on Debian
Taichung, TXG, Taiwan (estimated)

And looking at
https://accounts.firefox.com/settings/clients?service=sync
(you may need to try a different browser (bug 790369 ) to see it)
shows

jidanni's firefox on jidanni5
last sync 3 days ago
Epiphany 3.26, Debian
last sync 9 days ago
Epiphany 3.26, Debian
last sync 9 days ago
Epiphany 3.26, Debian
last sync 16 days ago
Aurora on ASUS_Z012DA
last sync a month ago

Big problem. The machine's name gets stripped.

$ uname -a
Linux jidanni7 4.13.0-1-amd64 #1 SMP Debian 4.13.10-1 (2017-10-30) x86_64 GNU/Linux

Somehow you are sending the Debian field instead of the jidanni7 field.

However on Preferences > Sync one sees
jidanni's GNOME Web on jidanni7

That is good. The problem is that is not what is getting sent to sync
headquarters!
Comment 1 Gabriel Ivașcu 2017-11-15 15:54:22 UTC
(In reply to Dan Jacobson from comment #0)
> Big problem. The machine's name gets stripped.
> 
> $ uname -a
> Linux jidanni7 4.13.0-1-amd64 #1 SMP Debian 4.13.10-1 (2017-10-30) x86_64
> GNU/Linux
> 
> Somehow you are sending the Debian field instead of the jidanni7 field.
> 
> However on Preferences > Sync one sees
> jidanni's GNOME Web on jidanni7

Good observation. This actually worked as intended some time ago, but apparently some changes in the Firefox Accounts Content Server (which handles the content displayed on https://accounts.firefox.com/) modified the behavior.

I'll have to investigate this and find what Mozilla has changed, so I can come up with a patch for Epiphany too.

> That is good. The problem is that is not what is getting sent to sync
> headquarters!

The device name specified in Epiphany's preferences dialog together with other device parameters that are not configurable by users are stored on the Sync Storage Server in the clients collection. This can be easily verified by inspecting the content of the collection on the server (either by using one of Mozilla's client implementations for the Sync Storage Server or building Epiphany from sources and using the sync-debug module).
Comment 2 Gabriel Ivașcu 2017-11-15 16:09:51 UTC
I notice now another thing which I bet is related to this too: the open tabs uploaded by Epiphany are not visible in Firefox's Synced Tabs dialog, because the Epiphany device is not visible by Firefox at all. (However, the open tabs from Firefox are visible in Epiphany's Synced Tabs dialog.)

This is something that also used to work, but broke recently.
Comment 3 Gabriel Ivașcu 2017-11-26 00:36:40 UTC
Created attachment 364400 [details] [review]
sync: Fix incorrect device name on accounts.firefox.com

This also fixes Epiphany's synced tabs not being viewable in Firefox.
Comment 4 Gabriel Ivașcu 2017-11-26 00:41:14 UTC
Created attachment 364401 [details] [review]
sync: Fix incorrect device name on accounts.firefox.com

This also fixes Epiphany's synced tabs not being viewable in Firefox.
Comment 5 Michael Catanzaro 2017-11-27 04:41:28 UTC
Review of attachment 364401 [details] [review]:

Oh boy!
Comment 6 Gabriel Ivașcu 2017-11-27 13:37:16 UTC
Attachment 364401 [details] pushed as 6a6e448 - sync: Fix incorrect device name on accounts.firefox.com