Created attachment 363485 [details] [review]
[PATCH] Allow pulseaudio to amplify volume key

Review of attachment 363485 [details] [review]:

Please follow the commit message pattern used by previous commits.

::: schemas/org.gnome.desktop.sound.gschema.xml.in
@@ +17,3 @@
       <description>Whether to play sounds on input events.</description>
     </key>
+    <key type="b" name="allow-amplified-volume">

"Amplified volume" doesn't mean "above 100%". Be clear about the fact that this is a software solution to a hardware problem, and the risks it causes.

@@ +19,3 @@
+    <key type="b" name="allow-amplified-volume">
+      <default>false</default>
+      <summary>Allow pulseaudio to amplify volume</summary>

There's no need to mention PulseAudio in the schema.

@@ +20,3 @@
+      <default>false</default>
+      <summary>Allow pulseaudio to amplify volume</summary>
+      <description>Whether the volume slider and multimedia keys allows setting the volume above 100%.</description>

Just those 2?

Created attachment 363571 [details] [review]
[PATCH] schemas: Add a gsettings key to be able to set volume above 100%

Thanks for the review! I tried to reformulate and hope this fits more.

I'll update the other patch to read the new schema once merged.

Review of attachment 363571 [details] [review]:

Looks good.

Created attachment 363572 [details] [review]
schemas: Add setting about whether to allow volume above 100%

Attachment 363572 [details] pushed as da7eab3 - schemas: Add setting about whether to allow volume above 100%