After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790033 - Add support for third stylus button on Wacom's new Pro Pen 3D
Add support for third stylus button on Wacom's new Pro Pen 3D
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on: 790028
Blocks:
 
 
Reported: 2017-11-07 18:36 UTC by Jason Gerecke
Modified: 2018-01-30 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clutter/evdev: Add support for BTN_STYLUS3 (1.54 KB, patch)
2017-11-07 18:54 UTC, Jason Gerecke
committed Details | Review
backends: Add support for Wacom stylus tertiary-button-action (5.72 KB, patch)
2017-11-07 18:54 UTC, Jason Gerecke
committed Details | Review
wayland: Add support for BTN_STYLUS3 (1.32 KB, patch)
2017-11-07 18:55 UTC, Jason Gerecke
committed Details | Review

Description Jason Gerecke 2017-11-07 18:36:36 UTC
Wacom has introduced a new "Pro Pen 3D" which includes a third barrel button. GNOME does not have support for this third button: g-c-c does not provide a way to configure its operation (see bug 790028) and mutter/gtk does not allow the use of this button.
Comment 1 Jason Gerecke 2017-11-07 18:54:24 UTC
Created attachment 363169 [details] [review]
clutter/evdev: Add support for BTN_STYLUS3

Note that BTN_STYLUS3 hasn't been formally accepted upstream quite yet...
Comment 2 Jason Gerecke 2017-11-07 18:54:52 UTC
Created attachment 363170 [details] [review]
backends: Add support for Wacom stylus  tertiary-button-action
Comment 3 Jason Gerecke 2017-11-07 18:55:52 UTC
Created attachment 363171 [details] [review]
wayland: Add support for BTN_STYLUS3

GTK+ patch. Above note about BTN_STYLUS3 applies.
Comment 4 Jason Gerecke 2017-11-13 16:09:47 UTC
Note: BTN_STYLUS3 has been accepted for the 4.15 kernel

https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/?h=for-4.15/wacom&id=9e429d564926d3bca49907fa03031da705ad6f2c
Comment 5 Carlos Garnacho 2018-01-24 20:28:38 UTC
Review of attachment 363169 [details] [review]:

Makes sense.
Comment 6 Carlos Garnacho 2018-01-24 20:30:29 UTC
Review of attachment 363170 [details] [review]:

Looks good.

::: src/backends/native/meta-input-settings-native.c
@@ +532,3 @@
                                                   GDesktopStylusButtonAction  primary,
+                                                  GDesktopStylusButtonAction  secondary,
+                                                  GDesktopStylusButtonAction  tertiary)

Starting to regret the explicit arguments instead of an array of those, but oh well :)
Comment 7 Carlos Garnacho 2018-01-24 20:32:01 UTC
Review of attachment 363171 [details] [review]:

LGTM
Comment 8 Carlos Garnacho 2018-01-30 20:15:34 UTC
Comment on attachment 363169 [details] [review]
clutter/evdev: Add support for BTN_STYLUS3

Attachment 363169 [details] pushed as 91df801 - clutter/evdev: Add support for BTN_STYLUS3
Comment 9 Carlos Garnacho 2018-01-30 20:36:11 UTC
Comment on attachment 363170 [details] [review]
backends: Add support for Wacom stylus  tertiary-button-action

Attachment 363170 [details] was committed too.
Comment 10 Carlos Garnacho 2018-01-30 20:38:15 UTC
Comment on attachment 363171 [details] [review]
wayland: Add support for BTN_STYLUS3

The GTK+ patch has been pushed to master and gtk-3-22. git bz is not friends with me today...