GNOME Bugzilla – Bug 790028
Support Wacom's new "Pro Pen 3D" and its third stylus button
Last modified: 2018-02-07 15:51:25 UTC
Wacom has just announced a new "Pro Pen 3D" [1] for their latest generation of tablets. This pen includes a third barrel button which is intended to be particularly useful in applications where one frequency uses pan, zoom, and rotate to navigate around a scene or model. This new pen is not fully supported by GNOME for two reasons: 1) the gnome-control-center offers no way to configure the use of the third button; 2) mutter has no support for a third stylus button. This bug is focused on resolving the first issue. A separate bug will be opened for the second issue. It should be mentioned that patches to support this pen are being added at other layers in the stack below us (e.g. kernel, xf86-input-wacom, libwacom) and that GNOME patches to add support may have dependencies on those updates. [1]: http://wacomcintiqpro.wacom.com/en-us#WacomProPen3D
Created attachment 363163 [details] [review] wacom: Set combo-topbutton to current value for styli with > 2 buttons
Created attachment 363164 [details] [review] wacom: Make remove_buttons dynamic
Created attachment 363165 [details] [review] wacom: Add support for three-button styli
Created attachment 363166 [details] [review] wacom: Support the WSTYLUS_3D stylus type Depends on libwacom accepting a patch for the new "WSTYLUS_3D" pen type
Created attachment 363168 [details] [review] schemas: Add tertiary-button-action for Wacom styli Patch for gsettings-desktop-schemas which adds a new "tertiary-button-action" that gnome-control-center can use to store settings for the new button.
Note: WSTYLUS_3D has now been accepted into libwacom https://sourceforge.net/p/linuxwacom/libwacom/ci/8896ed28cff26255aece4a4e964a2c8ef5a8fa51/
Comment on attachment 363163 [details] [review] wacom: Set combo-topbutton to current value for styli with > 2 buttons LGTM
Review of attachment 363164 [details] [review]: Okay. Had to read twice to check if n was the buttons to delete or preserve, and where it'd start from :). Won't bikeshed about it, still looks like an improvement over the two functions.
Review of attachment 363165 [details] [review]: The svg files are not added to relevant build rules (would be outdated anyway after the switch to meson :). I've got this change locally, and other than that looks good to me.
Review of attachment 363166 [details] [review]: ::: panels/wacom/cc-wacom-tool.c @@ +253,3 @@ case WSTYLUS_CLASSIC: return "wacom-stylus-classic"; + case WSTYLUS_3D: What version is this defined since? I guess we need some ifdef magic.
Review of attachment 363168 [details] [review]: Looks good
(In reply to Carlos Garnacho from comment #10) > Review of attachment 363166 [details] [review] [review]: > > ::: panels/wacom/cc-wacom-tool.c > @@ +253,3 @@ > case WSTYLUS_CLASSIC: > return "wacom-stylus-classic"; > + case WSTYLUS_3D: > > What version is this defined since? I guess we need some ifdef magic. Should be libwacom 0.27 which introduced this.
Comment on attachment 363168 [details] [review] schemas: Add tertiary-button-action for Wacom styli Attachment 363168 [details] pushed as b2b9114 - schemas: Add tertiary-button-action for Wacom styli
Made the missing meson.build changes and pushed to master. Thanks! Attachment 373163 [details] pushed as 0c65e04 - wacom: Set combo-topbutton to current value for styli with > 2 buttons Attachment 363164 [details] pushed as 69e9448 - wacom: Make remove_buttons dynamic Attachment 363165 [details] pushed as 039f30a - wacom: Add support for three-button styli Attachment 363166 [details] pushed as f57a192 - wacom: Support the WSTYLUS_3D stylus type
(In reply to Carlos Garnacho from comment #13) > Comment on attachment 363168 [details] [review] [review] > schemas: Add tertiary-button-action for Wacom styli > > Attachment 363168 [details] pushed as b2b9114 - schemas: Add > tertiary-button-action for Wacom styli Please get those patches filed in the correct module, so the maintainers of said modules can have a look.