After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787845 - VPN menu is always visible
VPN menu is always visible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.26.x
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-18 15:26 UTC by Piotr Drąg
Modified: 2018-01-10 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: Fix visibility of VPN section (1.08 KB, patch)
2018-01-07 20:27 UTC, Florian Müllner
committed Details | Review

Description Piotr Drąg 2017-09-18 15:26:37 UTC
The VPN submenu is always visible, even if I don’t have any VPN connections, or even any VPN software installed.

gnome-shell-3.26.0-1.fc27.x86_64
Comment 1 António Fernandes 2017-12-12 10:51:29 UTC
I think this regression was introduced by commit f2a9467f91b2d34c5b8d7a653ff14562e2210015 which removed the _sync function, which set the actor visibility.

> -    _sync: function() {
> -        let nItems = this._connectionItems.size;
> -        this.item.actor.visible = (nItems > 0);
Comment 2 Florian Müllner 2018-01-07 20:27:12 UTC
Created attachment 366465 [details] [review]
network: Fix visibility of VPN section

Commit f2a9467f91b was too eager to simplify the code, and removed
the bits that hid the section in case no VPNs are set up - add them
back to fix the visibility.

Gah, I had the fix sitting around locally and forgot to attach it :-(
Comment 3 Jonas Ådahl 2018-01-10 03:46:30 UTC
Review of attachment 366465 [details] [review]:

lgtm
Comment 4 Florian Müllner 2018-01-10 09:12:18 UTC
Attachment 366465 [details] pushed as f91fbd7 - network: Fix visibility of VPN section