After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786520 - network: Launch the appropriate settings panels
network: Launch the appropriate settings panels
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-19 16:29 UTC by Florian Müllner
Modified: 2017-12-19 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Launch the appropriate settings panels (3.02 KB, patch)
2017-08-19 16:29 UTC, Florian Müllner 		committed Details | Review
network: Simplify and fix VPN settings menu item (2.01 KB, patch)
2017-08-20 16:01 UTC, Rui Matos 		committed Details | Review

Description Florian Müllner 2017-08-19 16:29:11 UTC 
See patch.
Comment 1 Florian Müllner 2017-08-19 16:29:18 UTC 
Created attachment 357983 [details] [review]
network: Launch the appropriate settings panels

The new control-center shell split wifi configuration from the network
panel, and moved all other devices into a flat list. So instead of
manually spawning the app with the 'show-device' subcommand, we can
now simply launch the appropriate settings panel.
Comment 2 Rui Matos 2017-08-20 15:36:07 UTC 
Review of attachment 357983 [details] [review]:

sure
Comment 3 Rui Matos 2017-08-20 16:01:35 UTC 
Created attachment 358019 [details] [review]
network: Simplify and fix VPN settings menu item

As in the previous commit and furthermore it doesn't make much sense
to change the menu item according to the number of connections since
all connections here of the same type: VPN.
Comment 4 Florian Müllner 2017-08-20 16:06:22 UTC 
Comment on attachment 357983 [details] [review]
network: Launch the appropriate settings panels

Attachment 357983 [details] pushed as b2b2f65 - network: Launch the appropriate settings panels
Comment 5 Florian Müllner 2017-08-20 16:08:11 UTC 
Review of attachment 358019 [details] [review]:

Indeed.
Comment 6 Rui Matos 2017-08-21 10:15:11 UTC 
Attachment 358019 [details] pushed as f2a9467 - network: Simplify and fix VPN settings menu item