GNOME Bugzilla – Bug 787294
apps-menu: GNOME Shell 3.25 complains about JS warnings
Last modified: 2017-10-13 13:35:11 UTC
Created attachment 359158 [details] Log file capturing the JS warning from the GNOME Shell In short, on Ubuntu 17.10 the GNOME Shell 3.25.91 complains about two JS warnings when the apps-menu extension is enabled: 1) JS WARNING: [.../extension.js 65]: Too many arguments to method Clutter.Actor.add_child: expected 1, got 2 2) JS WARNING: [.../extension.js 361]: "0"-prefixed octal literals and octal escape sequences are deprecated; for octal literals use the "0o" prefix instead For more details see the log file.
Created attachment 359159 [details] [review] Patch file that fixes the first JS warning This patch file fixes the first JS warning by removing the extra argument, which seems to be unnecessary, since the method Clutter.Actor.add_child takes only a single argument as documented in [1]. [1] https://developer.gnome.org/clutter/stable/ClutterActor.html#clutter-actor-add-child
Created attachment 359160 [details] [review] Patch file that fixes the second JS warning The second patch file fixes the second JS warning by using the "0o" prefix, as advised by the JS warning message.
Review of attachment 359160 [details] [review]: LGTM, thanks
Review of attachment 359159 [details] [review]: The lines in the commit body are too long, otherwise looks good (it's probably more interesting to point to commit 63653406a3f as the source of the bug than referencing line numbers or Clutter's API docs, but it doesn't really matter)
Thanks for the feedback, Florian. As a newcomer, I will hopefully get it right next time :-). Cheers, Alexander
We are no longer in hard code freeze, so pushing (with slightly modified commit messages).
*** Bug 784197 has been marked as a duplicate of this bug. ***