After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784197 - js warning: octal literals and octal es cape sequences are deprecated
js warning: octal literals and octal es cape sequences are deprecated
Status: RESOLVED DUPLICATE of bug 787294
Product: gnome-shell
Classification: Core
Component: extensions
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-26 05:37 UTC by xiaoguang wang
Modified: 2017-10-13 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace octal literals with parseInt (1.00 KB, patch)
2017-06-26 05:46 UTC, xiaoguang wang 		reviewed Details | Review

Description xiaoguang wang 2017-06-26 05:37:00 UTC 
Login as gnome-classic session, there is JS WARNING.

JS WARNING: [/usr/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions.gcampax.github.com/extension.js 361]: octal literals and octal escape sequences are deprecated
Comment 1 xiaoguang wang 2017-06-26 05:46:07 UTC 
Created attachment 354471 [details] [review]
Replace octal literals with parseInt
Comment 2 Florian Müllner 2017-06-26 07:20:04 UTC 
Review of attachment 354471 [details] [review]:

::: extensions/apps-menu/extension.js
@@ +359,3 @@
                 try {
                     let info = o.query_info_finish(res);
+                    let mode = info.get_attribute_uint32(modeAttr) | parseInt("0100", 8);

Yeah, that code got in before I learned about the weird non-deprecated syntax to write octal numbers: 0o100. We should use that.
Comment 3 Florian Müllner 2017-10-13 13:35:11 UTC 
This has been fixed in the meantime.

*** This bug has been marked as a duplicate of bug 787294 ***