GNOME Bugzilla – Bug 785742
Migrated from Intltool to Gettext
Last modified: 2017-08-12 20:11:54 UTC
Created attachment 356792 [details] [review] Migrated from Intltool to Gettext This patch migrates translations from intltool to gettext. It depends on meson build port patch as it uses meson's i18n module.
Review of attachment 356792 [details] [review]: Did you verify that the .pot file could still be extracted, and that the desktop file did get translated? Looks good otherwise.
Thank you for reviewing this. Yes, I had checked it, but in case I've missed something I reviewed everything thoroughly again. It's working fine and all the strings are extracted. Although it may not be interesting enough, meson port also extracts the 'Icon' string from the 'sendto/bluetooth-sendto.desktop.in.in', which is one of the default keywords[0]. [0] http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/src/read-desktop.c#n643
(In reply to Iñigo Martínez from comment #2) > Although it may not be interesting enough, meson port also extracts the > 'Icon' string from the 'sendto/bluetooth-sendto.desktop.in.in', which is one > of the default keywords[0]. > That’s https://savannah.gnu.org/support/?108887
Oh! I wasn't aware of the discussion behind the 'Icon' key. Thanks for pointing it to me :)
(In reply to Iñigo Martínez from comment #2) > Thank you for reviewing this. Yes, I had checked it, but in case I've missed > something I reviewed everything thoroughly again. It's working fine and all > the strings are extracted. Looks fine to commit then, thanks.
Done. Pushed as e8ad2ad.