After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785737 - Port to meson build system
Port to meson build system
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks: 782980 785742
 
 
Reported: 2017-08-02 14:31 UTC by Iñigo Martínez
Modified: 2017-08-11 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port to meson build system (19.85 KB, patch)
2017-08-02 14:31 UTC, Iñigo Martínez
none Details | Review
Remove autotools (24.24 KB, patch)
2017-08-02 14:32 UTC, Iñigo Martínez
none Details | Review
Port to meson build system (22.95 KB, patch)
2017-08-07 08:45 UTC, Iñigo Martínez
accepted-commit_now Details | Review
Remove autotools (24.36 KB, patch)
2017-08-07 08:46 UTC, Iñigo Martínez
accepted-commit_now Details | Review

Description Iñigo Martínez 2017-08-02 14:31:18 UTC
Created attachment 356784 [details] [review]
Port to meson build system

Complete port to meson build system.
Comment 1 Iñigo Martínez 2017-08-02 14:32:30 UTC
Created attachment 356785 [details] [review]
Remove autotools

Some applications are removing autotools once they acquire a complete meson build port.

This patch removes autotools in case it is considered.
Comment 2 Iñigo Martínez 2017-08-02 14:34:55 UTC
Just in case it helps, I have also created a wip branch to test the meson port[0].

[0] https://git.gnome.org/browse/gnome-bluetooth/log/?h=wip/inigomartinez/meson
Comment 3 Iñigo Martínez 2017-08-07 08:45:09 UTC
Created attachment 357090 [details] [review]
Port to meson build system

An update to the meson build system which add its files into autotools files as extra files, so they are also included in the distributable package.
Comment 4 Iñigo Martínez 2017-08-07 08:46:28 UTC
Created attachment 357091 [details] [review]
Remove autotools

A follow up to the meson port patch update.
Comment 5 Bastien Nocera 2017-08-11 09:34:26 UTC
Review of attachment 357090 [details] [review]:

This looks correct overall. Feel free to commit this to master.

::: meson.build
@@ +2,3 @@
+  'gnome-bluetooth', 'c',
+  version: '3.20.1',
+  license: 'GPL2',

GPLv2+
Comment 6 Bastien Nocera 2017-08-11 09:36:03 UTC
Review of attachment 357091 [details] [review]:

Please create a gnome-3-20 branch (yes, gnome-3-20) before committing those 2 patches to master.
Comment 7 Iñigo Martínez 2017-08-11 15:16:43 UTC
I have created the gnome-3-20 branch with the last commit in master: 7cd3120 "Update Malayalam translation". Then I have applied these patches as a4c9c93 and 92b1faa, both of them pointing to this bug.

I have also removed the wip branch.