After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783097 - omx: add support for Zynq UltraScale+
omx: add support for Zynq UltraScale+
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-25 14:26 UTC by Guillaume Desmottes
Modified: 2017-07-03 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add 'zynqultrascaleplus' as OMX target (5.66 KB, patch)
2017-05-25 14:26 UTC, Guillaume Desmottes
committed Details | Review
omxh264enc: set 'parsed=true' on src caps (1.38 KB, patch)
2017-05-29 13:46 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2017-05-25 14:26:22 UTC
We are working on integrating gst-omx for the Zynq UltraScale+ board. This is the first commit to do so.
Comment 1 Guillaume Desmottes 2017-05-25 14:26:40 UTC
Created attachment 352579 [details] [review]
add 'zynqultrascaleplus' as OMX target

Adding support for the 'Zynq UltraScale+' as a new OMX target.

See https://www.xilinx.com/products/silicon-devices/soc/zynq-ultrascale-mpsoc.html
for details about the platform.
Comment 2 Tim-Philipp Müller 2017-05-25 14:39:06 UTC
I'm guessing there will be more patches? :)
Comment 3 Guillaume Desmottes 2017-05-25 14:41:03 UTC
(In reply to Tim-Philipp Müller from comment #2)
> I'm guessing there will be more patches? :)

Yes, adding extra features. But I'll split them up. This one is already usable as it so can already be reviewed and merged.
Comment 4 Sebastian Dröge (slomo) 2017-05-25 14:42:13 UTC
That's enough to make it run? If not, please add all the other commits here too.
Comment 5 Tim-Philipp Müller 2017-05-25 14:49:40 UTC
I think we should collect all the patches before starting to merge things to see if it's something we want to have upstream or not, which may depend on how intrusive the patches are.
Comment 6 Guillaume Desmottes 2017-05-25 15:00:59 UTC
(In reply to Sebastian Dröge (slomo) from comment #4)
> That's enough to make it run? If not, please add all the other commits here
> too.

Yes it is. With just this patch we can already use the H264 encoder and decoder on the board.

The other patches (which I still have to clean-up/rebase) are extra features such as new properties, DMA support, etc which, I think, should be discussed/merged separately as they are not required to have the existing code working.
Comment 7 Guillaume Desmottes 2017-05-29 13:46:59 UTC
Created attachment 352769 [details] [review]
omxh264enc: set 'parsed=true' on src caps

Allow to remove h264parse from pipeline and so remove the latency
introduced by the parser.
Comment 8 Guillaume Desmottes 2017-06-29 14:55:13 UTC
Comment on attachment 352769 [details] [review]
omxh264enc: set 'parsed=true' on src caps

No longer needed once bug #784344 will have been fixed.
Comment 9 Nicolas Dufresne (ndufresne) 2017-07-03 14:17:07 UTC
Thanks. I do think long term we'll need to re-org a bit if the number
of target becomes large, but in the mean time this seems to be the way
forward.

Attachment 352579 [details] pushed as 2be1214 - add 'zynqultrascaleplus' as OMX target