After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784344 - omxh264dec: remove 'parsed=true' from sink pad
omxh264dec: remove 'parsed=true' from sink pad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-29 14:52 UTC by Guillaume Desmottes
Modified: 2017-06-29 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omxh264dec: remove 'parsed=true' from sink pad (1.09 KB, patch)
2017-06-29 14:53 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2017-06-29 14:52:54 UTC
.
Comment 1 Guillaume Desmottes 2017-06-29 14:53:09 UTC
Created attachment 354694 [details] [review]
omxh264dec: remove 'parsed=true' from sink pad

The decoder only requires to receive one frame per buffer which is
already enforced with 'alignment=au'. There is no need to require to
have a parser upstream.

Allow to run "encode ! decode" pipeline without having a parser.
Comment 2 Nicolas Dufresne (ndufresne) 2017-06-29 19:48:50 UTC
Thanks. For those interested, this reflect what we do in other decoder
like avdec_h264. I thought initially that there might be other case, but other
formats don't seem to have an equivalent to alignment. I think it has to be looked
up case by case.

Attachment 354694 [details] pushed as 7525448 - omxh264dec: remove 'parsed=true' from sink pad