GNOME Bugzilla – Bug 782823
Add a "footnote" role
Last modified: 2017-05-25 06:34:50 UTC
ATK now has a "footnote" role. See bug 748384. We need to add support for it in AT-SPI2. N.B. This bug depends on bug 782820 because we need the role in at-spi2-core.
Created attachment 352144 [details] [review] proposed patch Mike, please review. Thanks!
Comment on attachment 352144 [details] [review] proposed patch Lgtm.
Comment on attachment 352144 [details] [review] proposed patch Thanks for the review! Committed. https://git.gnome.org/browse/at-spi2-atk/commit/?id=565f33b
Hi This patch breaks the build for me: [ 40s] Making all in . [ 40s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/at-spi2-atk-2.25.2/atk-adaptor' [ 40s] CC libatk_bridge_2_0_la-accessible-leasing.lo [ 40s] CC libatk_bridge_2_0_la-accessible-cache.lo [ 40s] CC libatk_bridge_2_0_la-accessible-stateset.lo [ 40s] CC libatk_bridge_2_0_la-object.lo [ 40s] CC libatk_bridge_2_0_la-introspection.lo [ 40s] CC libatk_bridge_2_0_la-bridge.lo [ 40s] CC libatk_bridge_2_0_la-event.lo [ 40s] CC libatk_bridge_2_0_la-accessible-register.lo [ 40s] CC libatk_bridge_2_0_la-spi-dbus.lo [ 40s] event.c: In function 'emit_event': [ 40s] event.c:489:67: warning: unused variable 'iter_array' [-Wunused-variable] [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, iter_array; [ 40s] ^~~~~~~~~~ [ 40s] object.c: In function 'init_role_lookup_table': [ 40s] object.c:485:14: error: 'ATK_ROLE_FOOTNOTE' undeclared (first use in this function) [ 40s] role_table[ATK_ROLE_FOOTNOTE] = ATSPI_ROLE_FOOTNOTE; [ 40s] ^~~~~~~~~~~~~~~~~ [ 40s] object.c:485:14: note: each undeclared identifier is reported only once for each function it appears in [ 40s] event.c:489:53: warning: unused variable 'iter_variant' [-Wunused-variable] [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, iter_array; [ 40s] ^~~~~~~~~~~~ [ 40s] make[3]: *** [Makefile:611: libatk_bridge_2_0_la-object.lo] Error 1 [ 41s] make[3]: *** Waiting for unfinished jobs.... Reverting it allows at-spi2-atk-2.25.2 to build, (have not checked if it works ok though).
(In reply to Bjørn Lie from comment #4) > Hi > > This patch breaks the build for me: > > [ 40s] Making all in . > [ 40s] make[3]: Entering directory > '/home/abuild/rpmbuild/BUILD/at-spi2-atk-2.25.2/atk-adaptor' > [ 40s] CC libatk_bridge_2_0_la-accessible-leasing.lo > [ 40s] CC libatk_bridge_2_0_la-accessible-cache.lo > [ 40s] CC libatk_bridge_2_0_la-accessible-stateset.lo > [ 40s] CC libatk_bridge_2_0_la-object.lo > [ 40s] CC libatk_bridge_2_0_la-introspection.lo > [ 40s] CC libatk_bridge_2_0_la-bridge.lo > [ 40s] CC libatk_bridge_2_0_la-event.lo > [ 40s] CC libatk_bridge_2_0_la-accessible-register.lo > [ 40s] CC libatk_bridge_2_0_la-spi-dbus.lo > [ 40s] event.c: In function 'emit_event': > [ 40s] event.c:489:67: warning: unused variable 'iter_array' > [-Wunused-variable] > [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, > iter_array; > [ 40s] > ^~~~~~~~~~ > [ 40s] object.c: In function 'init_role_lookup_table': > [ 40s] object.c:485:14: error: 'ATK_ROLE_FOOTNOTE' undeclared (first use > in this function) > [ 40s] role_table[ATK_ROLE_FOOTNOTE] = ATSPI_ROLE_FOOTNOTE; > [ 40s] ^~~~~~~~~~~~~~~~~ > [ 40s] object.c:485:14: note: each undeclared identifier is reported only > once for each function it appears in > [ 40s] event.c:489:53: warning: unused variable 'iter_variant' > [-Wunused-variable] > [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, > iter_array; > [ 40s] ^~~~~~~~~~~~ > [ 40s] make[3]: *** [Makefile:611: libatk_bridge_2_0_la-object.lo] Error 1 > [ 41s] make[3]: *** Waiting for unfinished jobs.... > > Reverting it allows at-spi2-atk-2.25.2 to build, (have not checked if it > works ok though). The problem is that there is not release yet using of ATK with that new role. I need to roll a new ATK release and we need to update at-spi2-atk dependencies. I was waiting for some patches before doing it. As soon as I get the green light I will do the release.
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #5) > (In reply to Bjørn Lie from comment #4) > > Hi > > > > This patch breaks the build for me: > > > > [ 40s] Making all in . > > [ 40s] make[3]: Entering directory > > '/home/abuild/rpmbuild/BUILD/at-spi2-atk-2.25.2/atk-adaptor' > > [ 40s] CC libatk_bridge_2_0_la-accessible-leasing.lo > > [ 40s] CC libatk_bridge_2_0_la-accessible-cache.lo > > [ 40s] CC libatk_bridge_2_0_la-accessible-stateset.lo > > [ 40s] CC libatk_bridge_2_0_la-object.lo > > [ 40s] CC libatk_bridge_2_0_la-introspection.lo > > [ 40s] CC libatk_bridge_2_0_la-bridge.lo > > [ 40s] CC libatk_bridge_2_0_la-event.lo > > [ 40s] CC libatk_bridge_2_0_la-accessible-register.lo > > [ 40s] CC libatk_bridge_2_0_la-spi-dbus.lo > > [ 40s] event.c: In function 'emit_event': > > [ 40s] event.c:489:67: warning: unused variable 'iter_array' > > [-Wunused-variable] > > [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, > > iter_array; > > [ 40s] > > ^~~~~~~~~~ > > [ 40s] object.c: In function 'init_role_lookup_table': > > [ 40s] object.c:485:14: error: 'ATK_ROLE_FOOTNOTE' undeclared (first use > > in this function) > > [ 40s] role_table[ATK_ROLE_FOOTNOTE] = ATSPI_ROLE_FOOTNOTE; > > [ 40s] ^~~~~~~~~~~~~~~~~ > > [ 40s] object.c:485:14: note: each undeclared identifier is reported only > > once for each function it appears in > > [ 40s] event.c:489:53: warning: unused variable 'iter_variant' > > [-Wunused-variable] > > [ 40s] DBusMessageIter iter, iter_dict, iter_dict_entry, iter_variant, > > iter_array; > > [ 40s] ^~~~~~~~~~~~ > > [ 40s] make[3]: *** [Makefile:611: libatk_bridge_2_0_la-object.lo] Error 1 > > [ 41s] make[3]: *** Waiting for unfinished jobs.... > > > > Reverting it allows at-spi2-atk-2.25.2 to build, (have not checked if it > > works ok though). > > The problem is that there is not release yet using of ATK with that new > role. I need to roll a new ATK release and we need to update at-spi2-atk > dependencies. > > I was waiting for some patches before doing it. As soon as I get the green > light I will do the release. I'm not sure if the green light you are waiting for is from me (i.e. the new AtkRelation types, which are committed to ATK master) or not. But if you're waiting on me, please roll the release. And apologies to all for breaking the build. Since I have locally-built packages in my environment, I didn't notice. Sorry!!
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #5) > > > > Reverting it allows at-spi2-atk-2.25.2 to build, (have not checked if it > > works ok though). > > The problem is that there is not release yet using of ATK with that new > role. I need to roll a new ATK release and we need to update at-spi2-atk > dependencies. > > I was waiting for some patches before doing it. As soon as I get the green > light I will do the release. ATK 2.25.2 just released. Bug to bump the atk dependency of at-spi2-atk here: https://bugzilla.gnome.org/show_bug.cgi?id=783074