After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748384 - We need a "footnote" role
We need a "footnote" role
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-23 19:22 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2017-05-19 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (995 bytes, patch)
2017-05-17 10:43 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2015-04-23 19:22:44 UTC 
It came up in the context of LibreOffice. [1] And DPUB is adding ARIA roles -- one of which is footnote. Turns out we don't have a footnote role. I think we should.

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=90724
Comment 1 Joanmarie Diggs (IRC: joanie) 2017-05-17 10:43:41 UTC 
Created attachment 352017 [details] [review]
proposed patch

Please review. Thanks!
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2017-05-19 07:12:57 UTC 
Review of attachment 352017 [details] [review]:

LGTM. Thanks.
Comment 3 Joanmarie Diggs (IRC: joanie) 2017-05-19 07:17:05 UTC 
Comment on attachment 352017 [details] [review]
proposed patch

Thanks for the review! Committed. https://git.gnome.org/browse/atk/commit/?id=bf71ccc