After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782822 - Add a "footnote" role
Add a "footnote" role
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
At-spi maintainer(s)
Depends on: 782820
Blocks:
 
 
Reported: 2017-05-19 08:17 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2019-03-27 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.28 KB, patch)
2017-05-19 08:19 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2017-05-19 08:17:45 UTC
ATK now has a "footnote" role. See bug 748384. We need to add support for it in AT-SPI2.

N.B. This bug depends on bug 782820 because we need the role in at-spi2-core.
Comment 1 Joanmarie Diggs (IRC: joanie) 2017-05-19 08:19:40 UTC
Created attachment 352143 [details] [review]
proposed patch

Mike, please review. Thanks!
Comment 2 Mike Gorse 2017-05-19 10:05:35 UTC
Comment on attachment 352143 [details] [review]
proposed patch

Lgtm.
Comment 3 Joanmarie Diggs (IRC: joanie) 2017-05-19 10:36:37 UTC
Comment on attachment 352143 [details] [review]
proposed patch

Thanks for the review! Committed. https://git.gnome.org/browse/pyatspi2/commit/?id=f131128