After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779116 - Convert from Gtk.Action to GLib.Action
Convert from Gtk.Action to GLib.Action
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
master
Other Linux
: High normal
: 0.13.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 766133
Blocks: 730682 766601
 
 
Reported: 2017-02-23 04:00 UTC by Michael Gratton
Modified: 2017-10-20 01:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Gratton 2017-02-23 04:00:00 UTC 
Need to finish off converting from Gtk.Action to GLib.Action so we can also clean up things like shortcut handling and hopefully address Bug 766601.
Comment 1 Michael Gratton 2017-10-15 11:01:46 UTC 
Niels, did you say you had a branch for this somewhere? Or was I imagining that?
Comment 2 Michael Gratton 2017-10-15 11:22:30 UTC 
Oh, I just found the patch for it, attached to Bug 713991! It seems to apply to master fine still, if you're happy with it I'd be pretty happy to commit that ASAP.
Comment 3 Niels De Graef 2017-10-17 23:01:04 UTC 
I haven't checked that commit in quite a while, but normally it should work, so if you're ok with it, so am I :-)
Comment 4 Michael Gratton 2017-10-20 01:08:41 UTC 
Sounds legit! :) Found a few minor things after running it for a few days, now merged with a few tweaks to master as commit 9d7e649. Ta!
Comment 5 Michael Gratton 2017-10-20 01:16:12 UTC 
For the record, there's a few uses of Gtk.Action left in the composer since WebKitGTK < 2.18 still requires them, so we are stuck with that until we can depend on 2.18, and some are left in the accounts dialog that I imagine will be fixed along with Bug 714104. The commit above removes the great majority of uses of Gtk.Action however, so I'm happy to close this.