GNOME Bugzilla – Bug 713991
Remove deprecated GTK widgets
Last modified: 2019-01-29 05:33:47 UTC
---- Reported by jim@yorba.org 2013-09-13 13:49:00 -0700 ---- Original Redmine bug id: 7485 Original URL: http://redmine.yorba.org/issues/7485 Searchable id: yorba-bug-7485 Original author: Jim Nelson Original description: A number of widgets are being deprecated in GTK that directly affect Geary. Gtk.ActionGroup has been, and we should anticipate deprecation of Gtk.UIManager and more later. Replacing all this is a bit of work, but it's the only way to prepare Geary to be ready for GTK 4. The completion of this ticket should include removing the "--enable- deprecations" flag we currently use with valac. Related issues: related to geary - 7457: Deprecations in latest Vala 0.21.2 (Fixed) ---- Additional Comments From geary-maint@gnome.bugs 2013-11-14 17:16:00 -0800 ---- ### History #### #1 Updated by Jim Nelson 2 months ago * **Description** updated (diff) #### #2 Updated by Jim Nelson 7 days ago * **Target version** deleted (<strike>_0.5.0_</strike>) --- Bug imported by chaz@yorba.org 2013-11-21 20:24 UTC --- This bug was previously known as _bug_ 7485 at http://redmine.yorba.org/show_bug.cgi?id=7485 Unknown version " in product geary. Setting version to "!unspecified". Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Created attachment 352259 [details] [review] [Patch] Port Gtk.Action to GLib.Action and remove UiManager Got really annoyed with the Gtk.Actions in the GearyController (and were in my way as well for the action needed to implement GNotifications), so I got rid of them and ported them to GAction's. That led to a lot of code being able to be deleted (and getting rid of Gtk.UiManager), which led me to post the patch to this bug. Some remarks of my own (read the commit message for most of the info): * There is now an extra action ACTION_MARK_AS_NOT_SPAM. Normally, one would give ACTION_MARK_AS_SPAM a boolean state, but that give an ugly, unavoidable checkbox in the mark menu. * Porting the keybindings to CSS should not be too much a problem, which is good news for the keybindings-related bugs * I'm not really sure how to handle the Gtk.MenuButtons for the move & copy menu more properly, since setting their action_name property doesn't seem to make them open their popover.
Created attachment 352273 [details] [review] [Patch v2] Port Gtk.Action to GLib.Action and remove UiManager Same patch, but this time added the necessary lines to POTFILES.in.
Review of attachment 352273 [details] [review]: Looks good! Pushed to master as commit 1dddceb.
This all landed a long time ago.