Created attachment 345388 [details] [review]
backend: Set "Add %s Account" as title for Add Account dialog

I noticed this because just about every other dialog in gnome-control-center uses Title Case except for this one.

Here's a possibly better link to the mockups:

https://wiki.gnome.org/Design/SystemSettings/OnlineAccounts#Tentative_Design

From #gnome-design on GIMPNet:

14:51 <rishi> aday: jimmac: jbicha filed these 2 bugs:                          
      https://bugzilla.gnome.org/show_bug.cgi?id=778417 and                     
      https://bugzilla.gnome.org/show_bug.cgi?id=778416
14:51 <rishi> How about just dropping the " account" suffix?
14:52 <rishi> Just "Google" when showing it, and "Add Google" when adding it.
14:53 <Lapo__> rishi: makes sense
14:53 <Lapo__> rishi: android does that
14:55 <Lapo__> rishi: I think microsoft account is like that since there's      
      exchange as well which is another thing
14:56 <Lapo__> but yeah, it should be just Microsoft and Microsoft Exchange
14:56 <rishi> Lapo__: It's called Microsoft Account, because MS' brand          
      identity has always been tricky. Ask jimmac :)
14:56 <rishi> I added a comment with references to past discussions.
14:56 <Lapo__> rishi: yeah I know
14:56 <rishi> Ok. Thanks, Lapo__ 
14:56 <Lapo__> rishi: messy more than tricky :-)
14:57 <Lapo__> Microsoft account used to be windows live account
14:57 <rishi> *nod*
14:57 <Lapo__> which used to be msn account
14:57 <Lapo__> and so on, they're marketing dept changes stuff pretty           
      frequently

Review of attachment 345388 [details] [review]:

::: src/goabackend/goautils.c
@@ +325,3 @@
   provider_name = goa_provider_get_provider_name (GOA_PROVIDER (provider), NULL);
   /* Translators: the %s is the name of the provider. eg., Google. */
+  title = g_strdup_printf (_("Add %s Account"), provider_name);

This is complicated by the fact that this function is also used for the "refresh account" dialog. That's the dialog when you click "sign in" on an account marked as needing attention. In the past we used "Refresh %s" as the title, but nobody was happy with the word "refresh". See bug 683692

I doubt we'll be able to come up with a satisfactory word, given that we already had a round of bikeshedding in the past. I am open to suggestions, though.

(By the way, here is another issue with the refresh dialog: bug 780096)

So, for the short term, how about settling for "%s Account" (with a capital A) instead? It's at least consistent with the title of the "show account" dialog.

Created attachment 348010 [details] [review]
utils: Capitalize "Account" in the dialog's title

This is what I meant in my previous comment.

I'm fine with either "Google Account" or "Add Google Account" being used for both adding and re-authenticating a Google account.

It's too bad that show_page_account is in gnome-control-center instead; otherwise, just using "%s Account" wouldn't be a string freeze break, right?

(In reply to Jeremy Bicha from comment #7)
> I'm fine with either "Google Account" or "Add Google Account" being used for
> both adding and re-authenticating a Google account.

Ok.

> It's too bad that show_page_account is in gnome-control-center instead;
> otherwise, just using "%s Account" wouldn't be a string freeze break, right?

Yes, you are right. I tried to move all the title setting to gnome-control-center, but the "refresh dialog" is completely self-contained inside gnome-online-accounts, so we'd need to change the string there anyway.

I am hoping that the solution to bug bug 780096 would involve creating the "refresh dialog" in gnome-control-center, just like the "add dialog". If that happens maybe all the titles can be consolidated in one place.

Comment on attachment 348010 [details] [review]
utils: Capitalize "Account" in the dialog's title

Pushed. Freeze exception granted.