After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778086 - Silently fails when installing a broken flatpakref
Silently fails when installing a broken flatpakref
Status: RESOLVED OBSOLETE
Product: gnome-software
Classification: Applications
Component: Flatpak
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-02 15:08 UTC by Allan Day
Modified: 2018-01-24 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allan Day 2017-02-02 15:08:08 UTC
I downloaded the Spotify .flatpakref and used Software to install it. First I hit bug 778082. Then I press install.

The progress bar filled to 100% and then the app page immediately went back to its initial state with the install button.

The flatpakref file is actually broken because Spotify changed the download URL - when you try to install it from the command line, you get a 404.

In cases like this,

 1. The progress bar shouldn't get to 100%
 2. Software ought to explain that it couldn't find the app download
Comment 1 Matthias Clasen 2017-07-07 22:49:45 UTC
I've tried the following:
download the spotify.flatpakref
break it by appending an x to the repo url
run gnome-software on it

I get an empty window with a spinner
the verbose log has an error message pretty much right away:

22:47:28:0167 Gs  failed to convert URL to GsApp: no application was created for running url-to-app with refine-flags=require-icon with failure-flags=use-events with search=file:///home/mclasen/Downloads/spotify.flatpakref

but the spinner window keep spinning forever...
Comment 2 Richard Hughes 2017-07-10 09:39:51 UTC
For the spinner:

commit 495a8e254ae942018af596639c97d086e236f1b4 (HEAD -> master)
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Jul 10 10:37:07 2017 +0100

    trivial: Go back to the overview page if the file or URL failed to be converted

For handling the error it's a bit more tricky; libflatpak just gives us:

g-io-error-quark:G_IO_ERROR_FAILED:GPG verification enabled, but no summary signatures found (use gpg-verify-summary=false in remote config to disable)

Which implies it's a GPG error rather than a URI issue. There's also no error code that can be sensibly checked. I don't think just showing the error string would be helpful at all, and a generic "Failed to parse file" is as useful as a chocolate teapot.
Comment 3 Richard Hughes 2017-07-10 09:40:27 UTC
(to clarify, this is the error from flatpak_installation_fetch_remote_metadata_sync)
Comment 4 Allan Day 2017-07-10 12:05:33 UTC
"Sorry, something went wrong" (or equivalent) is better than nothing at all (although still not as good as it should be).
Comment 5 Richard Hughes 2017-07-11 07:25:32 UTC
commit cb834b91166fa8a484ae6d96ff625636f7f91db7 (HEAD -> master)
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Jul 11 08:24:15 2017 +0100

    trivial: Always show a notification when we have a pending error
    
    Show a 'Sorry, something went wrong' in-app error when we have no proper
    translation to show.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=778086
Comment 6 GNOME Infrastructure Team 2018-01-24 17:27:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-software/issues/142.