After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776272 - add disk usage refresh button
add disk usage refresh button
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
: 793793 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-12-19 14:00 UTC by Cedric Bosdonnat
Modified: 2018-02-25 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add reload menu option to the locations list. (3.61 KB, patch)
2017-04-28 10:55 UTC, Gabriel Rauter
none Details | Review
Patch to add reload menu option to the locations list. (3.63 KB, patch)
2017-04-28 12:00 UTC, Gabriel Rauter
none Details | Review
Add a timeout to regularly update disk usage information (2.09 KB, patch)
2017-10-29 09:40 UTC, Stefano Facchini
committed Details | Review

Description Cedric Bosdonnat 2016-12-19 14:00:33 UTC
The disk usage page never refreshes. It would be great to have a refresh button to avoid exiting baobab and starting it again to update the disk usages.
Comment 1 Gabriel Rauter 2017-04-28 10:55:51 UTC
Created attachment 350630 [details] [review]
Patch to add reload menu option to the locations list.

This patch adds a menu option to reload the current location list. For this it calls LocationList.update (), which is otherwise already automatically called on mount changes.

In addition LocationList.update () now also calls updated Location.update () for each location so file-system sizes also get updated. Location.update () was altered to handle main volume, home folder and recent files.

Not sure if some sort of visual feedback is needed so the user knows the list was updated?

The "<Primary>r" accelerator already works to refresh the list. F5 should be probably added as an additional accelerator. That could be implemented as part of bug 762557.
Comment 2 Gabriel Rauter 2017-04-28 12:00:00 UTC
Created attachment 350635 [details] [review]
Patch to add reload menu option to the locations list.

Fix sftp mounts.

Not sure if I encountered a bug or it is intended behavior to not mark sftp mounts as remote locations.
Comment 3 Stefano Facchini 2017-10-29 09:40:27 UTC
Created attachment 362478 [details] [review]
Add a timeout to regularly update disk usage information

I prefer to automatically update the disk usage, instead of having to press a refresh button.

As for the sftp mount not being recognized as remote, it was indeed another bug. A fix was commited for that, too.
Comment 4 Stefano Facchini 2017-10-29 09:41:20 UTC
Attachment 362478 [details] pushed as 9dbfb01 - Add a timeout to regularly update disk usage information
Comment 5 Stefano Facchini 2018-02-25 10:33:05 UTC
*** Bug 793793 has been marked as a duplicate of this bug. ***