After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775447 - Grilo plugin needs quality column
Grilo plugin needs quality column
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: UPNP/DLNA Music sharing
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-01 09:15 UTC by Ben Walsh
Modified: 2017-04-09 21:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Grilo: quality column. (3.70 KB, patch)
2016-12-01 09:21 UTC, Ben Walsh 		reviewed Details | Review
Grilo: quality column. (3.69 KB, patch)
2017-02-04 18:05 UTC, Ben Walsh 		committed Details | Review

Description Ben Walsh 2016-12-01 09:15:31 UTC 
When browsing DLNA, it's nice to see which files are high/low quality. I have a patch to add a quality column.
Comment 1 Ben Walsh 2016-12-01 09:21:32 UTC 
Created attachment 341126 [details] [review]
Grilo: quality column.
Comment 2 Jonathan Matthew 2016-12-11 10:35:52 UTC 
Review of attachment 341126 [details] [review]:

looks ok, except for one thing.

::: plugins/grilo/rb-grilo-source.c
@@ +633,3 @@
+		g_value_init (&v, G_TYPE_ULONG);
+		/* bps -> kbps. Round downwards. */
+		g_value_set_ulong (&v, bitrate / 1000);

grilo bitrates should already be in kbps, so I don't think this is correct.  I'm guessing you saw bps values coming from the dleyna plugin?
Comment 3 Ben Walsh 2016-12-12 19:27:24 UTC 
Oh yes. Good point. I looked through the grilo source for the units but didn't notice the "kbits/s" comment before.

My DLNA server (minidlna) is sending bps, so it looks like either minidlna should send kbps, or dleyna should do the conversion.

Before I get lost in the DLNA doc, do you have any idea which units DLNA should be quoting the bitrate in?
Comment 4 Ben Walsh 2017-02-04 18:05:41 UTC 
Created attachment 344943 [details] [review]
Grilo: quality column.
Comment 5 Ben Walsh 2017-02-04 18:08:00 UTC 
The DLNA standard states bits/second (see https://www.dlna.org/guidelines).

I got this fixed in the grilo dleyna plugin (https://bugzilla.gnome.org/show_bug.cgi?id=777210).

New patch attached.
Comment 6 Jonathan Matthew 2017-04-09 21:40:33 UTC 
Review of attachment 344943 [details] [review]:

pushed as commit fb088da