After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777210 - dleyna-plugin: should convert from bits/second to kbits/second
dleyna-plugin: should convert from bits/second to kbits/second
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-13 09:38 UTC by Ben Walsh
Modified: 2017-02-04 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dleyna: convert bytes/s to kbits/s. (1.00 KB, patch)
2017-01-14 08:24 UTC, Ben Walsh 		rejected Details | Review
dleyna: convert bits/s to kbits/s. (1019 bytes, patch)
2017-01-19 20:44 UTC, Ben Walsh 		accepted-commit_now Details | Review

Description Ben Walsh 2017-01-13 09:38:06 UTC 
I have a patch to fix this:

UPNP should state bitrate in bytes/second (see http://www.upnp.org/schemas/av/didl-lite-v2.xsd). dleyna-plugin should convert this to kbits/second.
Comment 1 Ben Walsh 2017-01-14 08:24:59 UTC 
Created attachment 343473 [details] [review]
dleyna: convert bytes/s to kbits/s.
Comment 2 Ben Walsh 2017-01-19 20:44:48 UTC 
Created attachment 343844 [details] [review]
dleyna: convert bits/s to kbits/s.
Comment 3 Ben Walsh 2017-01-19 20:46:57 UTC 
Review of attachment 343473 [details] [review]:

Checked DLNA guidelines and it should be bits/second.
Comment 4 Ben Walsh 2017-01-19 20:46:59 UTC 
Review of attachment 343473 [details] [review]:

Checked DLNA guidelines and it should be bits/second.
Comment 5 Ben Walsh 2017-01-19 20:48:35 UTC 
I checked the DLNA guidelines at https://www.dlna.org/guidelines/ and it's bits/second, not bytes/second as per the UPNP spec.

But it still needs a conversion to kbits/second.
Comment 6 Victor Toso 2017-02-04 15:08:52 UTC 
Review of attachment 343844 [details] [review]:

Hi Ben,

Sorry for taking some time to review your patch.

The bitrate metadata-key is Kbits/s, so converting to Kbits is correct.
Took me awhile to find in the protocol, that it uses bits/s, what has conviced me is the following:

> This guideline defines the concept of bitrate. An example of a maximum combined
> value for a bitrate parameter for an object.item.videoitem containing a video component of 5 Mbps,
> an audio track of 1 Mbps, and system overhead bitrate of 30 Kbps would be 6030000.

I'll be pushing this shortly.
Comment 7 Victor Toso 2017-02-04 15:13:02 UTC 
Oh, forgot to git bz push it.

pushed as 1d93ae1199d445de07dd6720ec94e973c1695f66
Comment 8 Ben Walsh 2017-02-04 17:52:22 UTC 
Great. Thanks!