GNOME Bugzilla – Bug 775170
missing mono testing icons in sound panel
Last modified: 2018-01-12 21:43:13 UTC
Created attachment 340839 [details] mono speaker test Saw this recently
The missing icon names are "audio-speaker-mono-testing" and "audio-speaker-mono".
Looks like the sound panel ship these pixmaps. Makes sense to add to the set there. Also some styling tweaks are due.
Created attachment 360463 [details] [review] sound: update artwork - restyle all assets symbolic - add missing mono speaker
Just reproduced this one on Endless as well. Ubuntu worked it around so far by symlinking to audio-speaker-center*[1], but I personally would rather integrate the proposal here, including the style changes. Any chance this will land soon? [1] https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1704002
Review of attachment 360463 [details] [review]: definitely looks good. unfortunately it break the UI freeze on stable that's why I didn't push it yet, but let's do it now
Sounds good. @Jakub: would you mind pushing your patch to master then?
Attachment 360463 [details] pushed as 8bfd0b9 - sound: update artwork
Relates to https://bugzilla.gnome.org/show_bug.cgi?id=780546 There are still 4 icons missing.
I've just noticed this patch is in the master branch but it's not in the gnome-3-26 branch. @Rui, any reason not to push it there?
(In reply to Mario Sánchez Prada from comment #9) > I've just noticed this patch is in the master branch but it's not in the > gnome-3-26 branch. @Rui, any reason not to push it there? Rui doesn't work for RH anymore, so probably won't be looking at GNOME patches for a while. The patch (in commit 8bfd0b97d6a4af2fdf3db5d8920d22db4b5f3106) changes the style of the icons, so is a UI change that we can't apply to a stable branch. Please file a new bug, and attach a patch for gnome-3-26 within the existing style if you want it fixed in that version.
(In reply to Bastien Nocera from comment #10) > (In reply to Mario Sánchez Prada from comment #9) > > I've just noticed this patch is in the master branch but it's not in the > > gnome-3-26 branch. @Rui, any reason not to push it there? > > Rui doesn't work for RH anymore, so probably won't be looking at GNOME > patches for a while. The patch (in commit > 8bfd0b97d6a4af2fdf3db5d8920d22db4b5f3106) changes the style of the icons, so > is a UI change that we can't apply to a stable branch. Oops! Right... the patch landed after 3.26 got released, doesn't make sense to apply on the stable branch, sorry. > Please file a new bug, and attach a patch for gnome-3-26 within the existing > style if you want it fixed in that version. No problem, we're good backporting this one ourselves, no need to force things. Thanks for clarifying, I completely overlooked that fact :)