After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773890 - network: Always show primary icon when connected
network: Always show primary icon when connected
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 734577 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-03 13:06 UTC by Florian Müllner
Modified: 2017-01-21 02:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Always show primary icon when connected (1.82 KB, patch)
2016-11-03 13:06 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-11-03 13:06:20 UTC 
See patch.
Comment 1 Florian Müllner 2016-11-03 13:06:25 UTC 
Created attachment 339018 [details] [review]
network: Always show primary icon when connected

The top bar's network menu only supports a subset of device types
supported by NetworkManager. While not having lesser used options
in the menu itself is perfectly reasonable, not showing any network
icon at all in the top bar when the system is fully connected is
weird.
Comment 2 Rui Matos 2016-11-07 14:40:12 UTC 
Review of attachment 339018 [details] [review]:

looks good

::: js/ui/status/network.js
@@ +2098,3 @@
                 this._primaryIndicator.icon_name = dev.getIndicatorIcon();
+            else if (connected)
+                this._primaryIndicator.icon_name = 'network-wired-symbolic';

for this case we could also check if this._client.connectivity == NetworkManager.ConnectivityState.FULL and use network-wired-no-route-symbolic otherwise
Comment 3 Florian Müllner 2016-11-10 13:41:29 UTC 
Attachment 339018 [details] pushed as b6cd548 - network: Always show primary icon when connected
Comment 4 Michael Catanzaro 2017-01-21 02:07:12 UTC 
*** Bug 734577 has been marked as a duplicate of this bug. ***