After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772486 - Incorrect grammar in OS updates detailed description
Incorrect grammar in OS updates detailed description
Status: RESOLVED NOTABUG
Product: gnome-software
Classification: Applications
Component: General
3.22.x
Other Linux
: Normal minor
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-05 23:15 UTC by Rafal Luzynski
Modified: 2017-10-23 17:07 UTC
See Also:
GNOME target: ---
GNOME version: 3.23/3.24



Description Rafal Luzynski 2016-10-05 23:15:51 UTC
Please ignore this if I'm wrong but I think this grammar is incorrect:

+------------+------------------------------------------------------------+
| OS Updates | Includes performance, stability and security improvements. |

Shouldn't it read "Include performance, stability and security improvements" instead?

This issue has been already mentioned in bug 767634 comment 1 and in https://launchpad.net/bugs/1592001.

See the incorrect text location: https://git.gnome.org/browse/gnome-software/tree/src/gs-plugin-loader.c#n1226

I think the change is too trivial to provide a patch here.
Comment 1 Michael Catanzaro 2016-12-09 13:57:17 UTC
I don't think we should change this. I see where you're coming from, since you must say "OS updates include..." whereas "OS updates includes" would be clearly incorrect subject-verb agreement. But in this context, the description applies to one particular, singular set of OS updates. It's iffy, but I think it would sound worse to a native speaker if we remove the 's' here. An alternative that would sound better than "include" would be "including", but I kinda prefer the current text best.
Comment 2 Rafal Luzynski 2016-12-29 13:03:55 UTC
I am by no means an expert at the English language and I don't know if the author of the comment at https://launchpad.net/bugs/1592001 is. If you both say that it's correct in this context then it is.

Maybe a translators comment would be helpful saying that "is available" or "contains" or "has been installed" applies to "OS Updates" and although it's correct to use singular here in English the translators may prefer plural form if it's more appropriate in their languages.
Comment 3 Allan Day 2017-10-23 17:07:33 UTC
The current string reads fine in English. "OS Updates" is plural, but it is a single item in the UI - hence treating it in the singular.