GNOME Bugzilla – Bug 767634
Incorrect grammar in OS updates complete notification
Last modified: 2016-12-29 13:58:53 UTC
After installing OS updates the following notification is shown: "OS Updates is now installed" That should be: "OS Updates are now installed". The issue is the notification text was designed for an app, i.e. "APP is now installed". OS Updates are internally treated as an app called "OS Updates".
Similarly, the description for "OS Updates" on the Updates page reads "Includes performance, stability and security improvements" But I think it should read "Include performance, stability and security improvements"
Created attachment 336481 [details] [review] Use correct grammar when notifying OS updates have been installed.
Created attachment 336482 [details] [review] Use correct grammar when notifying OS updates have been installed. Tweaked the comment and the capitalisation of the string.
Please change it to the else on a single line (e.g. "} else {") and then push to master, thanks!
Also Please consider fixing the string according to what Jeremy suggested in comment 1: "Includes performance,... probably should be "Includes performance,... because the context is: "OS Updates Includes performance..." https://git.gnome.org/browse/gnome-software/tree/src/gs-plugin-loader.c#n1226 I think the change is too trivial to provide a patch.
You should really raise the other issue as a separate bug...