After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772135 - Instead of no-icon, indicate layer/channel/path/tool invisibility with eye-shut icon, no-iris-eye icon or well-delimited area in list
Instead of no-icon, indicate layer/channel/path/tool invisibility with eye-sh...
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 794619 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-28 18:40 UTC by Andrew
Modified: 2018-05-24 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
new visibility icons (21.90 KB, image/png)
2016-09-30 21:02 UTC, Andrew
Details

Description Andrew 2016-09-28 18:40:23 UTC
Layer/channels/Path dialog and Preference > Interface > toolbox should have a closed eye icon to indicate that the layer/channel/path/tool is invisible. 

Currently in the paths dialog you have no idea that you can check the visibility of paths until you select or hover over them in most themes. There just this weird empty space in the dialog. 

You can't just add the closed eye to the paths dialog because this would make the rest of GIMP very inconsistent. So to keep GIMP consistent the closed eye should be added to all these places.

This is how Inkscape, Mypaint, Krita and other apps present an invisible layers among other things. So users that are familiar with those apps will immediately know how GIMP works.
Comment 1 Michael Natterer 2016-09-28 19:07:18 UTC
We must also consider the difference between visible and viewable,
to see what I mean, make a layer group invisible.
Comment 2 Andrew 2016-09-28 19:27:09 UTC
Yah you can't see layer groups on the canvas but changing the visibility of the groups affects every layer in the group. You can also link and lock layer groups and it affects all the layers in that group. So it really does make sense that there would be an open and closed eye to show that the group is visible or invisible.
Comment 3 Michael Natterer 2016-09-29 07:25:46 UTC
I meant the appearance of the eye icon *inside* the group when you
make the group itself invisible. That needs to be considerer when
adding a "closed eye" icon there.
Comment 4 Michael Natterer 2016-09-29 07:26:08 UTC
"considered"
Comment 5 Andrew 2016-09-30 21:01:54 UTC
Oh ok I see what you mean. Well Currently if you have a group with visible layers and you make the group invisible a line appears to let the user know that the layer is visible but the group is not. This should happen with the closed eye as well. although I don't like how it is done currently. Currently GIMP makes the line not the icon theme maker.

There should be four states to the visibility icon: visible, invisible, visable_insensitive, invisable_insensitive.
Comment 6 Andrew 2016-09-30 21:02:30 UTC
Created attachment 336698 [details]
new visibility icons
Comment 7 Jehan 2018-03-25 16:50:15 UTC
Alternative proposals on bug 794619: eye without a pupil, or adding lines to clearly identify areas in the list.

I set this as 2.10 milestone, but mostly so that we can think about the various ideas and decide on the best path.
Comment 8 Jehan 2018-03-25 16:53:13 UTC
*** Bug 794619 has been marked as a duplicate of this bug. ***
Comment 9 Andrew 2018-03-25 19:43:48 UTC
Ultimately it really does not matter as to what the icon depicts but will be determined by the theme used. GIMP may want to use an eye without a pupil. As long as I can change the icon for my Flat GIMP Icon Theme I will be happy, and as long as there is an icon showing that the layer or whatever is hidden I think the users will be happy.
Comment 10 Jehan 2018-03-26 01:23:30 UTC
(In reply to Andrew from comment #9)
> Ultimately it really does not matter as to what the icon depicts but will be
> determined by the theme used. GIMP may want to use an eye without a pupil.
> As long as I can change the icon for my Flat GIMP Icon Theme I will be
> happy, and as long as there is an icon showing that the layer or whatever is
> hidden I think the users will be happy.

You are right that it doesn't matter for people as long as they have a different icon. But it matters for us because we have to make a choice for our themes. ;-)

Of course, third-party themes can choose different metaphors, that's not our call.

Also this other bug report actually had another proposition too which was to make clear separations in the list (attachment 370112 [details]) to make it more obvious that something in the visibility icon area can be done even when there are no icons.
Not sure yet what I think about this proposition.

Anyway we will need to think more about this later, but right now this is not our priority.
Comment 11 Andrew 2018-03-28 04:22:33 UTC
I am just pointing out that as long as there is a different icon to show the other state and that this icon is themeable(why would it not be) everyone should be happier.

I like the idea shown in your attachment. Currently, there is not a lot that can be done to dialogs to make them look more modern. a lot could be done to make dialogs look nicer and more themeable. I should probably make a new bug to showcase what I am talking about and give some ideas as to what could be done to make GIMP prettier. I know it is not a huge priority but whatever can be done to make it look prettier will make using GIMP a much more pleasant experience.
Comment 12 GNOME Infrastructure Team 2018-05-24 16:58:03 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/974.