After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772040 - Lack of feedback during flatpak update process
Lack of feedback during flatpak update process
Status: RESOLVED OBSOLETE
Product: gnome-software
Classification: Applications
Component: Flatpak
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Richard Hughes
Depends on:
Blocks:
 
 
Reported: 2016-09-27 09:54 UTC by Andreas Nilsson
Modified: 2018-01-24 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screencast (59.45 KB, video/webm)
2016-09-27 09:54 UTC, Andreas Nilsson
Details
another screencast (180.77 KB, video/webm)
2017-02-20 12:42 UTC, Allan Day
Details
screencast 1 (641.13 KB, video/webm)
2017-09-27 16:02 UTC, Chris Murphy
Details
screencast 2 (428.68 KB, video/webm)
2017-09-27 16:03 UTC, Chris Murphy
Details
screencast 3 (284.50 KB, video/webm)
2017-09-27 16:03 UTC, Chris Murphy
Details
gnome-software verbose (1.86 MB, text/plain)
2017-09-27 16:04 UTC, Chris Murphy
Details

Description Andreas Nilsson 2016-09-27 09:54:17 UTC
Created attachment 336325 [details]
screencast

There is a bit of lack of feedback what is going on during the update of flatpak bundles.

To reproduce:
* Press "Install All"
* Install All button grays out, the individual install buttons doesn't.
* At some point an install button grays out for an item in the list. Maybe that means that that individual bundle is being updated. Not sure.
* Items disappears in random order off the list.
Comment 1 Bastien Nocera 2016-10-11 15:36:50 UTC
Was about to file that same bug.

gnome-software-3.22.0-1.fc25.x86_64
Comment 3 Andreas Nilsson 2016-12-15 16:25:56 UTC
Allan suggested putting the progressbar in the button instead, so I'll create a variant with that tomorrow.
Comment 4 Andreas Nilsson 2016-12-16 11:09:43 UTC
Changed the mockup to have the progress in the buttons.
Comment 6 Allan Day 2017-02-16 14:47:27 UTC
I'm surprised it says "Install All"; maybe that's because you just have Flatpak updates?

I just experienced a similar issue. In my case, I had a mix of package and Flatpak updates, and the button said "Restart & Install". After I pressed the button it became insensitive and there was a pause; I honestly thought it had broken.

In addition to the too subtle progress information, and the randomness of the order in which the updates were installed, the transitions when the rows are removed from the list are rather abrupt and jerky.
Comment 7 Richard Hughes 2017-02-17 12:31:31 UTC
I think this is fixed in master now, we have the new sections in the update panel and the flatpak apps should report progress properly. Make sure you have the latest flatpak if you're using the external-apps functionality for this to work.
Comment 8 Allan Day 2017-02-20 12:42:38 UTC
Created attachment 346260 [details]
another screencast

I just tested master and I don't think this bug is fixed. The new headers are a definite improvement and should resolve bug 772974 (I say "should" because pressing "Restart & Update" didn't have any effect - probably a JHBuild issue). However, here's what happened when I updated Flatpaks by pressing "Update All":

 * All the individual "Update" buttons became insensitive and the label changed to "Installing". Two problems here:
  - The update button for one of the rows didn't become insensitive or have the label change (this is probably because I'd recently uninstalled the runtime - it should have been automatically removed from the update list, but wasn't).
  - The insensitive buttons should read "Updating", not "Installing".
 * The "Update All" button remained sensitive (it should have become insensitive).
 * No progress information was shown for each update operation.
 * After each update was installed, the "Update"/"Installing" button disappeared, but the row remained. It was unclear whether the update had been successful or not.
 * Then, all the updates in the list suddenly disappeared, except two which had update buttons next to them. Were these updates that failed to be installed? If someone presses "Update All", all the updates should be installed.
 * Then there's a brief flash - for a moment a different UI is shown - a blue "Restart & Update" button in the header bar and the middle of the window completely grey, with a "Downloading new updates..." heading in the middle - before the previous view is restored.

It would be better to hide each row after its update has completed (ideally using an animation, so the row collapses up).

I've attached a screencast of the process.
Comment 9 Richard Hughes 2017-02-20 14:21:46 UTC
See https://github.com/ostreedev/ostree/issues/697 for the lack of progressbar.
Comment 10 Allan Day 2017-02-20 15:55:58 UTC
(In reply to Richard Hughes from comment #9)
> See https://github.com/ostreedev/ostree/issues/697 for the lack of
> progressbar.

The progress bar would be nice, but it's not the most important issue here. The most serious issues are:

 * "Update All" not becoming insensitive.
 * The disappearance of the "installing" button. This could be as simple as the button staying visible and the label changing to "Complete".
 * Obvious behavioural bugs - updates being shown for things that are no longer installed, not everything getting updated, the UI briefly changing to something different.
Comment 11 Richard Hughes 2017-02-20 16:45:37 UTC
commit 99bc90b6bcdf8811d3837c2bf28179c7c5b44506
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Feb 20 16:44:51 2017 +0000

    Animate the removal of live updates
    
    Fixes some of https://bugzilla.gnome.org/show_bug.cgi?id=772040#c10
Comment 12 Richard Hughes 2017-02-20 16:54:03 UTC
commit 3bd30a7892b0431fe8033ae1f94551f91fcfff0d
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Feb 20 16:53:36 2017 +0000

    trivial: Mark the 'Update All' button insensitve when clicked
    
    When the updates list is rebuilt the widget is recreated from new.
    
    Fixes some of https://bugzilla.gnome.org/show_bug.cgi?id=772040#c10
Comment 13 Chris Murphy 2017-09-27 16:02:16 UTC
This is definitely still a bug in gnome-software-3.24.3-1.fc26.x86_64; from the original description reproduce steps.

- Click on Update All
- First flatpak app's Update button changes to Installing which is out of focus with an status bar indicator. Good.
- Upon completion of installing, that first app vanishes, and the next item (library) Update button changes to Installing which is out of focus with a status bar indicator. Also good.
- Upon completion, this 2nd item Installing button reverts to an in-focus Update button, and now there's no status of anything happening. Not good.
- The out of focus Update All button now becomes in focus and blue. Not good.
- The two remaining items (items 2 and 3) vanish for no apparent reason, their Update buttons never changed to Installing, there was no indicating they were ever updated. Not good.
- A fourth item, previously not listed (LibreOffice) now appears for updating. And it is not updated indefinitely. Not good.



Attaching 3 screencasts showing most of this behavior. And also gnome-software --verbose log that goes with those screencasts.
Comment 14 Chris Murphy 2017-09-27 16:02:42 UTC
Created attachment 360549 [details]
screencast 1
Comment 15 Chris Murphy 2017-09-27 16:03:05 UTC
Created attachment 360550 [details]
screencast 2
Comment 16 Chris Murphy 2017-09-27 16:03:20 UTC
Created attachment 360551 [details]
screencast 3
Comment 17 Chris Murphy 2017-09-27 16:04:24 UTC
Created attachment 360552 [details]
gnome-software verbose
Comment 18 Allan Day 2017-10-24 11:57:12 UTC
Testing 3.26.1, I think there's still work to do on this issue. Updating a bunch of Flatpaks, the individual update buttons for the runtimes don't become insensitive and don't show progress information.

The latest design work for how it should look can be seen here:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups-software/master/wireframes/updates-auto-on.png
Comment 19 GNOME Infrastructure Team 2018-01-24 17:17:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-software/issues/97.