After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772974 - Updates: "Restart and Install" does not restart immediately if flatpak updates available
Updates: "Restart and Install" does not restart immediately if flatpak update...
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: Flatpak
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Richard Hughes
Depends on:
Blocks:
 
 
Reported: 2016-10-15 08:27 UTC by Bastian Ilsø
Modified: 2017-10-24 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastian Ilsø 2016-10-15 08:27:11 UTC
When I press "Restart & Install" I expect restarting to happen immediately followed by installing updates as the label indicates. This usually works as expected except when in the case of flatpak updates. In this case, updates to flatpak applications seem to be installed first which can take several minutes long. This is problematic because:

1) it feels like I am not receiving the expected feedback from pressing the "Restart & Install" button (expected feedback being that my computer restarts). 

2) When there are many updates, the flatpak updates are obscured in the list, so I didn't suspect that something else was going on.


My suggestion would be to 1) restart first 2) handle system updates 3) handle flatpak updates in the background.

I am using gnome-software built from master.
Comment 1 Andreas Nilsson 2016-11-10 12:13:56 UTC
I ran across this issue too.
If there is a way to do the flatpak updates as part of the offline updates, I think that could be a good approach too.

Here are some mockups from earlier this year that suggests this kind of behaviour. It think it was Allan who made them.

https://github.com/gnome-design-team/gnome-mockups-software/blob/master/wireframes/atomic-updates-wires.png
Comment 2 Allan Day 2017-02-16 14:48:58 UTC
Just had this issue myself. It's pretty surprising that it doesn't trigger an immediate restart.
Comment 3 Andreas Nilsson 2017-02-16 14:55:05 UTC
(In reply to Bastian Ilsø from comment #0)

> My suggestion would be to 1) restart first 2) handle system updates 3)
> handle flatpak updates in the background.

So to do it after the system has rebooted into the new session?
The drawback of that would be that the notification that shows up after the reboot-and-update is done would only mention the system updates, or lie about the current state (it says firefox is updated, even though it's actually not, quite yet).
Comment 4 Allan Day 2017-02-16 16:25:10 UTC
The current design is to split out offline and online updates into separate operations:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups-software/master/wireframes/updates.png
Comment 5 Allan Day 2017-10-24 10:11:32 UTC
I think this issue was resolved during the 3.26.x cycle - the UI now follows the mockup I linked to above, so the restart and install button only refers to offline updates.