GNOME Bugzilla – Bug 771946
HeaderBar Label should not hexpand
Last modified: 2016-10-10 21:59:08 UTC
Created attachment 336217 [details] screenshot The Label showing the current mode in the HeaderBar (titlebar) has hexpand set. This was not previously honoured because HeaderBar did not support expanding children. However, as of GTK+ 3.22, it does, and this means that now the label expands to fill the available space in the titlebar. The result is that we end up with a really wide 'dropdown' (actually Popover!) in the titlebar. This looks strange (when highlighted or dragging the window) and pushes the associated down-arrow image away from the text, so it doesn't look like drop-downs (e.g. ComboBox) and is not obviously a drop-down widget. I'll attach a screenshot showing the extreme case of this, in Programming mode. Patch on the way (unless Lapo beats me to it. :D) HTH and thanks!
Also, the halign=baseline property on the Label appears not to do anything, and the Inspector shows it gets GTK_ALIGN_FILL at runtime. I think while making changes in that area, it might be prudent to remove that, unless it has some hidden purpose I'm missing...
Created attachment 336218 [details] [review] math-window.ui: do not expand mode Label, and add spacing between it and arrow This fixes the problem of the Label being overly wide, and the immediately following problem of it and the arrow now being too close together.
Created attachment 336219 [details] [review] math-window.ui: remove redundant halign=baseline on the mode Label This does not seem to be used, as the Inspector shows that the Label gets GTK_ALIGN_FILL anyway.
Created attachment 336223 [details] [review] math-window.ui: do not expand mode Label, and add spacing between it and the down-arrow add this bug url
Created attachment 336224 [details] [review] math-window.ui: remove redundant halign=baseline from mode Label add this bug url
I thinkhaving the downarrow so far aparr from the label, makes it less discoverable that you can click the label for mode switching. As a bonus it looks better.
Attachment 336223 [details] pushed as c45961d - math-window.ui: do not expand mode Label, and add spacing between it and the down-arrow Attachment 336224 [details] pushed as 1d44d6b - math-window.ui: remove redundant halign=baseline from mode Label
Thanks again Robert, glad I could help!