After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771829 - Headerbar manu-button label vertically off center
Headerbar manu-button label vertically off center
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-22 12:32 UTC by Lapo Calamandrei
Modified: 2016-09-25 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
centering fix patch (842 bytes, patch)
2016-09-22 12:32 UTC, Lapo Calamandrei 		committed Details | Review

Description Lapo Calamandrei 2016-09-22 12:32:41 UTC 
Created attachment 336080 [details] [review]
centering fix patch

The label on the main button in the headerbar is off center vertically, the patch  fixes by setting valign to center on the contained gtkgrid.
Comment 1 Robert Roth 2016-09-25 01:06:22 UTC 
Review of attachment 336080 [details] [review]:

Definitely better than before.
Comment 2 Daniel Boles 2016-09-25 14:12:11 UTC 
Should this label be hexpanded? It is, but that doesn't look very nice, and I'm pretty sure it did not do this before. Maybe it never showed up because HeaderBars previously did not support expanding children. Anyway, my personal vote would go to removing the hexpand property on the Label, so that it gets centered at an appropriate size.