After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771743 - Mouse panel very small when touchpad is present, on Wayland
Mouse panel very small when touchpad is present, on Wayland
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 772847 773336 773558 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-20 21:25 UTC by Armin K.
Modified: 2016-10-26 23:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (1.24 MB, image/png)
2016-09-20 21:25 UTC, Armin K.
  Details
mouse: Set min-content-height on the scrolled window (1.20 KB, patch)
2016-10-14 12:40 UTC, Felipe Borges
none Details | Review
mouse: Set min-content-height on the scrolled window (2.44 KB, patch)
2016-10-17 13:23 UTC, Felipe Borges
committed Details | Review

Description Armin K. 2016-09-20 21:25:38 UTC
Created attachment 335950 [details]
Screenshot

See the screenshot. Other panels with more options are bigger, so it would be nice if this one is too. I have to scroll down to see the touchpad options.
Comment 1 Bastien Nocera 2016-09-21 12:40:41 UTC
Which exact versions of gnome-control-center and GTK+ are you using?
Comment 2 Armin K. 2016-09-21 12:41:17 UTC
3.22.0
Comment 3 Bastien Nocera 2016-09-21 12:46:48 UTC
Might be a bug in 36cd7177fd40432cb4ae7db10e2571dbbd9604b9. There was an ordering problem in X11, might be another one there.
Comment 4 Bastien Nocera 2016-09-21 12:48:11 UTC
(In reply to Bastien Nocera from comment #3)
> Might be a bug in 36cd7177fd40432cb4ae7db10e2571dbbd9604b9. There was an
> ordering problem in X11, might be another one there.

Wrong bug.

It might be GTK+ playing with sizing again.
Comment 5 Atri 2016-09-23 19:41:00 UTC
Also seen on Xorg, so this bug is not specific to Wayland I think.
Comment 6 Ricardo Ramos 2016-10-12 00:18:56 UTC
I was about to report the same window issue...
Comment 7 Ben 2016-10-12 18:50:25 UTC
Still present on 3.22.1
Comment 8 Felipe Borges 2016-10-13 10:13:18 UTC
*** Bug 772847 has been marked as a duplicate of this bug. ***
Comment 9 Felipe Borges 2016-10-14 12:40:20 UTC
Created attachment 337715 [details] [review]
mouse: Set min-content-height on the scrolled window

Require the scrolled window which wraps the panel content to have
a minimum-content-height of 380.

380 is an estimated value based on the SMALL_SCREEN_FIXED_HEIGHT
(see shell/cc-window.c) minus 20px of tolerance considering corner
cases where there are large font settings (see commit 62f1f6b).
Comment 10 Ricardo Ramos 2016-10-14 14:22:50 UTC
I also created bugs for universal access, search, power and notification windows and my computer screen has 1366x768 pixels but those windows are not big enough vertically, it should stretch based on the resolution of the screen, It makes no sense to scroll down to reveal the rest of the options in a screen resolution like that.
Comment 11 Bastien Nocera 2016-10-17 12:29:37 UTC
(In reply to Ricardo Ramos from comment #10)
> I also created bugs for universal access, search, power and notification
> windows and my computer screen has 1366x768 pixels but those windows are not
> big enough vertically, it should stretch based on the resolution of the
> screen,

It's not the same problem as the one above, which is about the window becoming smaller than the "overview" section of the Settings shell but still requiring a scrollbar. Your problem will be fixed by the new shell design, as discussed in bug 773094.
Comment 12 Bastien Nocera 2016-10-17 12:36:04 UTC
Review of attachment 337715 [details] [review]:

I'd prefer the way the power panel does it in panels/power/cc-power-panel.c on_content_size_changed()
Comment 13 Felipe Borges 2016-10-17 13:23:19 UTC
Created attachment 337851 [details] [review]
mouse: Set min-content-height on the scrolled window

Set a minimum content height of 490px for the panel when the
allocated height is smaller than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes

This also drops the max-content-height limit for the scrolled window,
as it is no longer necessary.
Comment 14 Bastien Nocera 2016-10-22 15:15:17 UTC
*** Bug 773336 has been marked as a duplicate of this bug. ***
Comment 15 Bastien Nocera 2016-10-24 11:33:23 UTC
Attachment 337851 [details] pushed as 6b32333 - mouse: Set min-content-height on the scrolled window
Comment 16 Felipe Borges 2016-10-26 23:11:39 UTC
*** Bug 773558 has been marked as a duplicate of this bug. ***