GNOME Bugzilla – Bug 771424
consider configuring compress integration with file type -> open with, instead of through nautilus preferences
Last modified: 2017-09-04 10:21:20 UTC
I think it would be clearer if Nautilus' archive integration (automatic decompression on double click) would be configured the same way as all other default apps are configured - through file properties -> open with. There I could select whether I want to use nautilus automatic extraction, or file-roller, on double click. The downside is that this might require users to configure their preference for each archive type separately (or might not, I don't know how exactly "open with" works).
Yes, this please. I've already extracted the same archive five times, wondering why when I double-clicked on it, it didn't open in file-roller...
Agreed! I just spent half my afternoon trying to fix what I thought was a bug. Had also tried fixing it in the "Open with" dialog. Single clicks never delete or copy or anything, and unpacking an archive can be a massive operation! I guess this is nice if you only use archives for downloading movies, but the new behavior really isn't helpful for people who want to keep zip files stored on disk...
Created attachment 357285 [details] [review] nautilus.desktop: Remove saved-search leftovers It was removed long ago
Created attachment 357286 [details] [review] window-slot: Remove obsolete comment
Created attachment 357287 [details] [review] general: Add mime type support for archives Until now archives were managed only if activated from Nautilus itself and if a setting was set. There are two main problems with this. 1- Archives opened in other apps cannot be handled by Nautilus 2- Users cannot use the regular myme type handling for setting Nautilus as the app handling archives, or unsetting it. This patch add support for archives myme types handled by gnome-autoar and removes the UI and setting used in the previous version.
Review of attachment 357285 [details] [review]: Woo, more stuff removed!
Review of attachment 357286 [details] [review]: Maybe would be nice to have some context for the comment in the commit message, but it’s fine.
Review of attachment 357287 [details] [review]: Looks good, got some nitpicks and a question (you’re not responding ATM on IRC). Also, commit message: s/myme/MIME/g. ::: data/org.gnome.Nautilus.desktop.in @@ +12,3 @@ StartupNotify=true Categories=GNOME;GTK;Utility;Core;FileManager; +MimeType=inode/directory; application/x-7z-compressed; application/x-7z-compressed-tar; application/x-bzip; application/x-bzip-compressed-tar; application/x-compress; application/x-compressed-tar; application/x-cpio; application/x-gzip; application/x-lha; application/x-lzip; application/x-lzip-compressed-tar; application/x-lzma; application/x-lzma-compressed-tar; application/x-tar; application/x-tarz; application/x-xar; application/x-xz; application/x-xz-compressed-tar; application/zip; application/gzip; application/bzip2; This looks very Carlos. :D ::: src/nautilus-files-view.c @@ +1243,3 @@ NautilusWindowOpenFlags flags) { + g_autoptr(GList) files; It’s more traditional to NULL-initialize these everywhere. Also, don’t we leave a space between “g_autoptr” and the opening parenthesis? @@ +1247,1 @@ + files = g_list_append(NULL, file); Style! I’d also like it better if you passed files itself instead of NULL here, but, you know, whatever. :p @@ +7322,3 @@ + } + return TRUE; + Left an empty line here. ::: src/nautilus-window-slot.c @@ +1872,3 @@ + file_to_activate, 0); + } + } Do we really want to check if Nautilus is the default handler here? I might want to do one-off decompressions with Nautilus and this basically disallows that.
(In reply to Ernestas Kulik from comment #8) > Do we really want to check if Nautilus is the default handler here? I might > want to do one-off decompressions with Nautilus and this basically disallows > that. Nevermind, I’m forgetting keyboard activation.
Created attachment 357295 [details] [review] general: Add mime type support for archives Until now archives were managed only if activated from Nautilus itself and if a setting was set. There are two main problems with this. 1- Archives opened in other apps cannot be handled by Nautilus 2- Users cannot use the regular myme type handling for setting Nautilus as the app handling archives, or unsetting it. This patch add support for archives myme types handled by gnome-autoar and removes the UI and setting used in the previous version.
Review of attachment 357295 [details] [review]: Go for it (but, again, myme types?).
Created attachment 357296 [details] [review] general: Add mime type support for archives Until now archives were managed only if activated from Nautilus itself and if a setting was set. There are two main problems with this. 1- Archives opened in other apps cannot be handled by Nautilus 2- Users cannot use the regular mime type handling for setting Nautilus as the app handling archives, or unsetting it. This patch add support for archives mime types handled by gnome-autoar and removes the UI and setting used in the previous version.
Attachment 357285 [details] pushed as 8005c8a - nautilus.desktop: Remove saved-search leftovers Attachment 357286 [details] pushed as 3a353db - window-slot: Remove obsolete comment Attachment 357296 [details] pushed as 1bdc404 - general: Add mime type support for archives
*** Bug 772433 has been marked as a duplicate of this bug. ***