GNOME Bugzilla – Bug 770670
udisks2 backend requires gudev so configure should check for that
Last modified: 2016-10-19 11:20:12 UTC
Currently it is possible run configure like this ./configure --enable-udisks2 --disable-gudev This will enable the udisks2 backend and disable gudev support. As the udisks2 backend requires gudev, the resulting build will fail later. ./configure should disable the udisks2 backend if gudev support is not enabled. Patch attached.
Created attachment 334550 [details] [review] [PATCH] Disable udisks2 volume monitor if gudev is not available
Review of attachment 334550 [details] [review]: Thanks for the patch! ::: configure.ac @@ +248,3 @@ UDISKS2_REQUIRED=1.97 +if test "x$enable_udisks2" != "xno" -a "x$msg_gudev" = "xyes"; then It not possible to enable udisks2 at all with your patch, because msg_gudev is not set at this point. You have to move the whole udisks2 section under the gudev section to be sure msg_gudev is set correctly in all cases :-)
*** Bug 707046 has been marked as a duplicate of this bug. ***
Created attachment 334607 [details] [review] Disable udisks2 volume monitor if gudev is not available v2
Thanks for the review. I've moved the gudev check up, below the libudev check.
Review of attachment 334607 [details] [review]: Thanks, it looks good though it is not applicable without the patch from Bug 770671...
Comment on attachment 334607 [details] [review] Disable udisks2 volume monitor if gudev is not available v2 commit 4c4740f605edac7b55a417e244b7c1a7253ef6a2