After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707046 - --enable-udisks --disable-gudev fails to compile, add fix to configure.ac
--enable-udisks --disable-gudev fails to compile, add fix to configure.ac
Status: RESOLVED DUPLICATE of bug 770670
Product: gvfs
Classification: Core
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-29 12:38 UTC by Samuli Suominen
Modified: 2016-09-01 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prevent broken combination of --enable-udisks --disable-gudev (435 bytes, patch)
2013-08-29 12:38 UTC, Samuli Suominen 		needs-work Details | Review

Description Samuli Suominen 2013-08-29 12:38:55 UTC 
Created attachment 253495 [details] [review]
Prevent broken combination of --enable-udisks --disable-gudev

Bug was filed at http://bugs.gentoo.org/show_bug.cgi?id=482764 when user had a somewhat weird combination of ./configure flags, --enable-udisks but --disable-gudev

That causes GUDEV_CFLAGS and GUDEV_LIBS be unset, and the compile fails during 'make' step like:

make[3]: Entering directory `/tmp/gvfs-1.16.3/monitor/udisks2'
  CC       gvfs_udisks2_volume_monitor-udisks2volumemonitordaemon.o
In file included from udisks2volumemonitordaemon.c:33:0:
gvfsudisks2volumemonitor.h:32:25: fatal error: gudev/gudev.h: No such file or directory
 #include <gudev/gudev.h>
                         ^
compilation terminated.
make[3]: *** [gvfs_udisks2_volume_monitor-udisks2volumemonitordaemon.o] Error 1

The attached patch makes it impossible to run with this combination of ./configure flags
I guess other approaches could be taken as well, like silently not building the udisks backend with --disable-gudev, or enabling gudev despite of --disable-gudev
Comment 1 Ondrej Holy 2013-10-18 11:59:48 UTC 
Review of attachment 253495 [details] [review]:

::: configure.ac
@@ +338,3 @@
+AS_IF([test "x$enable_udisks" = "xyes" -a "x$enable_gudev" = "xno"],
+  [AC_MSG_ERROR([--enable-udisks without --enable-gudev is not supported])])
+

There should be enable_udisks2/enable-udisks2 instead of enable_udisks/enable-udisks probably. This cover case --enable-udisks2 --disable-gudev. However it doesn't work when user set only --disable-gudev, because --enable-udisks2 isn't set by default, in spite of udisks2 is build by default...
Comment 2 Ondrej Holy 2016-09-01 13:33:01 UTC 

*** This bug has been marked as a duplicate of bug 770670 ***