After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769598 - Add option to show Battery percentage in Top Bar
Add option to show Battery percentage in Top Bar
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
: 784304 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-07 04:53 UTC by Robin A. Meade
Modified: 2017-07-02 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add battery percentage on top bar (880 bytes, patch)
2017-06-06 08:27 UTC, Alberto Fanjul
none Details | Review
Add battery percentage switch under top bar section (1.52 KB, patch)
2017-06-07 04:23 UTC, Alberto Fanjul
committed Details | Review
Reorder Top bar components (1.60 KB, patch)
2017-06-13 19:27 UTC, Alberto Fanjul
committed Details | Review

Description Robin A. Meade 2016-08-07 04:53:27 UTC
In Gnome 3.20, the Battery Percentage can be shown with:

gsettings set org.gnome.desktop.interface show-battery-percentage true

Please add this option to Tweak Tool.
Comment 1 Nate Graham 2016-11-26 00:17:56 UTC
You can access it from dconf editor, FWIW. But if this is a really common request, then it should be in the most discoverable place: gnome-control-center. Or even enabled by default.
Comment 2 Alberto Fanjul 2017-06-06 08:27:51 UTC
Created attachment 353243 [details] [review]
Add battery percentage on top bar
Comment 3 Jeremy Bicha 2017-06-06 22:31:17 UTC
Review of attachment 353243 [details] [review]:

Thank you for working on this bug and submitting a patch.

Unless you hear different from Design, I think I'd prefer this setting in the Top Bar page. How about a "Battery Percentage" switch under a Power heading there?

By the way, git master has been converted to python3 and meson now.
Comment 4 Alberto Fanjul 2017-06-07 04:23:06 UTC
Created attachment 353289 [details] [review]
Add battery percentage switch under top bar section
Comment 5 Jeremy Bicha 2017-06-07 13:04:12 UTC
Thank you. I have pushed this now. I made two small changes:
1. I capitalized "Percentage" to match the other labels in the Top Bar panel.
2. I added this bug number to the git commit description. It can be added automatically if you use something like
git bz attach -e 769598

http://git.fishsoup.net/man/git-bz.html
http://git.fishsoup.net/cgit/git-bz/tree/git-bz

By the way, I intend to push a new gnome-tweak-tool 3.25 release today because I want to get some of these new features in Ubuntu 17.10 Alpha.
Comment 6 Alberto Fanjul 2017-06-07 13:08:26 UTC
Note taken for possible next contributions
Comment 7 Jeremy Bicha 2017-06-13 18:59:30 UTC
Alberto, could you please update the Top Bar panel to match the mockup that was updated today?

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png
Comment 8 Alberto Fanjul 2017-06-13 19:10:49 UTC
hands on it
Comment 9 Alberto Fanjul 2017-06-13 19:27:43 UTC
Created attachment 353703 [details] [review]
Reorder Top bar components

I found the only change is components order, am I right?

I don't know if mark prior patch as obsolete since it is committed
Comment 10 Jeremy Bicha 2017-06-13 19:34:44 UTC
I adjusted the first line of the commit message to better match the commit style and pushed this for you. Thank you!

There was no need to mark the other commit as obsolete since this one applies on top of that one.

By the way, I marked a few bugs for newcomers.
Comment 11 Jeremy Bicha 2017-07-02 12:02:20 UTC
*** Bug 784304 has been marked as a duplicate of this bug. ***