After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769584 - app: Always use a timestamp of 0 when requesting channels
app: Always use a timestamp of 0 when requesting channels
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks: 751575 769655
 
 
Reported: 2016-08-06 21:16 UTC by Florian Müllner
Modified: 2016-08-29 23:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app: Always use a timestamp of 0 when requesting channels (2.02 KB, patch)
2016-08-06 21:16 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2016-08-06 21:16:52 UTC
See patch.
Comment 1 Florian Müllner 2016-08-06 21:16:58 UTC
Created attachment 332865 [details] [review]
app: Always use a timestamp of 0 when requesting channels

Whether a join/query action should switch to the corresponding room is
determined by a timestamp contained in the action's parameter. We handle
that timestamp immediately to be responsive to user action, but currently
also pass it on to telepathy. As a result, mission-control will ask us to
present the room (again) when the channel is ready, which is pointless in
the best case. In the worst case when channel creation is slow (as during
startup, when joining multiple channels at once), the user might have
selected a different room while waiting for the connection to finish, in
which case the focus stealing is unexpected and rude.

Just use a timestamp of 0 for all channel requests we make ourselves, so
that we only present externally created channels that are handed over to
us (for example from GNOME Shell's builtin chat integration).
Comment 2 Florian Müllner 2016-08-07 01:43:01 UTC
This is part of a bigger patchset, so probably won't apply to master directly. To make it easy to try without hunting dependencies in bugs, I've pushed it as part of https://git.gnome.org/browse/polari/log/?h=wip%2Ffmuellner%2Fmisc-fixes
Comment 3 Rares Visalom 2016-08-08 20:32:35 UTC
Review of attachment 332865 [details] [review]:

looks good to me.
Comment 4 Florian Müllner 2016-08-29 23:29:11 UTC
Attachment 332865 [details] pushed as 9b63bf1 - app: Always use a timestamp of 0 when requesting channels