After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751575 - No Autojoin after signing into IRC.
No Autojoin after signing into IRC.
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
: 752294 (view as bug list)
Depends on: 769582 769583 769584 769592 769655
Blocks: 709982
 
 
Reported: 2015-06-27 06:31 UTC by Arcademan
Modified: 2016-08-29 23:31 UTC
See Also:
GNOME target: ---
GNOME version: 3.15/3.16


Attachments
telepathyClient: Connect accounts explicitly before creating channels (4.31 KB, patch)
2016-08-09 01:19 UTC, Florian Müllner
committed Details | Review

Description Arcademan 2015-06-27 06:31:47 UTC
I would think Polari would go and join channels after authentication (nickserv ajoin method like Geekshed IRC uses). It also would be nice to see if you could add a list for those networks like freenode where you join them manually. 

Also quick question: Is SASL supported yet on Polari?

Thanks, Arcade.
Comment 1 Bastian Ilsø 2015-06-27 12:35:39 UTC
Polari relies on telepathy-idle and telepathy-idle does not yet seem to support SASL (see https://bugs.freedesktop.org/show_bug.cgi?id=48380)
Comment 2 Florian Müllner 2016-02-12 20:47:58 UTC
*** Bug 752294 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2016-08-09 01:19:14 UTC
Created attachment 332970 [details] [review]
telepathyClient: Connect accounts explicitly before creating channels

We currently rely on mission-control automatically establishing server
connections when we request a channel. However we will soon support
NickServ identification, which means we may need to send an "identify"
message before joining any channels. This will be easier to achieve if
connecting to the server and joining channels are separate operations,
so stop relying on automatic presence changes and connect accounts
explicitly before creating any channels.
As a side effect, externally configured channels (a.k.a. autojoin) will
now work as expected, as we do not filter out enabled accounts without
rooms.
Comment 4 Bastian Ilsø 2016-08-16 12:57:36 UTC
Review of attachment 332970 [details] [review]:

looks good to me
Comment 5 Florian Müllner 2016-08-29 23:31:53 UTC
Attachment 332970 [details] pushed as 62224bb - telepathyClient: Connect accounts explicitly before creating channels