After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769066 - keyboard: Add gettext support for keybinding descriptions
keyboard: Add gettext support for keybinding descriptions
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
: 761881 (view as bug list)
Depends on:
Blocks: 769073 769074
 
 
Reported: 2016-07-22 01:14 UTC by Florian Müllner
Modified: 2016-07-27 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Add gettext support for keybinding descriptions (2.89 KB, patch)
2016-07-22 01:14 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-07-22 01:14:34 UTC 
Currently the keybinding descriptions we install for mutter/gnome-shell are the only files that still require intltool to extract translatable strings. However we can teach upstream gettext to do the job instead by providing some simple rules.

Also see the last section of https://blogs.gnome.org/mclasen/2016/07/21/using-modern-gettext/, which had absolutely nothing to do with this patch :-)
Comment 1 Florian Müllner 2016-07-22 01:14:40 UTC 
Created attachment 331947 [details] [review]
keyboard: Add gettext support for keybinding descriptions

gettext can extract strings from xml file formats with the help of
.its files. Provide appropriate rules so modules that install
keybinding descriptions don't need to depend on intltool to
extract translatable strings.
Comment 2 Florian Müllner 2016-07-27 15:29:21 UTC 
Attachment 331947 [details] pushed as f7fad92 - keyboard: Add gettext support for keybinding descriptions

Reviewed on IRC.
Comment 3 Alberts Muktupāvels 2016-07-27 15:35:15 UTC 
*** Bug 761881 has been marked as a duplicate of this bug. ***