After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761881 - keyboard: install gettext ITS files
keyboard: install gettext ITS files
Status: RESOLVED DUPLICATE of bug 769066
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-11 21:52 UTC by Alberts Muktupāvels
Modified: 2016-07-27 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: install gettext ITS files (2.27 KB, patch)
2016-02-11 21:52 UTC, Alberts Muktupāvels 		needs-work Details | Review

Description Alberts Muktupāvels 2016-02-11 21:52:20 UTC 
Created attachment 320912 [details] [review]
keyboard: install gettext ITS files

Recent gettext has a feature to allow consumer projects to supply
their own string extraction rules for XML files, in ITS format.
Comment 1 Bastien Nocera 2016-02-24 17:07:23 UTC 
I don't understand what that is for. Please expand.
Comment 2 Alberts Muktupāvels 2016-02-29 17:22:21 UTC 
If these files are installed in /usr/share/gettext/its then xgettext will be able to extract translatable string from keybindings files (files that are installed in /usr/share/gnome-control-center/keybindings).

These files are installed already by:
1) gtk+ - https://git.gnome.org/browse/gtk+/commit/?id=f9e6ccd59256ef86bdfa3bfe9810df35f7ee00fe
2) glib - https://git.gnome.org/browse/glib/commit/?id=50645b724a3b43767fd57e4af53365d0cd270382
3) appstream-glib - https://github.com/hughsie/appstream-glib/commit/2f98b73d42fc65e9c1c3feaefe0ba1fe0fd1b66e

Only it might be good idea to change keybindings file extension from .xml to .keybindings.xml (probably supporting both - old and new one). If you are interested I could create patches.
Comment 3 Bastien Nocera 2016-03-02 12:02:51 UTC 
Can you explain that in the commit message for the patch?
Comment 4 Bastien Nocera 2016-03-02 12:03:25 UTC 
Review of attachment 320912 [details] [review]:

Commit message doesn't explain what this does, as per bug comments.
Comment 5 Alberts Muktupāvels 2016-07-27 15:35:15 UTC 

*** This bug has been marked as a duplicate of bug 769066 ***