Created attachment 329205 [details] [review]
afc: Fix iOS 7 trust dialogue handling

There are new iOS 7 related error codes that we need to handle to catch
cases where a user action is required on the device.

Review of attachment 329205 [details] [review]:

::: daemon/gvfsbackendafc.c
@@ +603,3 @@
+
+    if (lerr != LOCKDOWN_E_PASSWORD_PROTECTED &&
+        lerr != LOCKDOWN_E_PAIRING_DIALOG_PENDING)

error: ‘LOCKDOWN_E_PAIRING_DIALOG_PENDING’ undeclared (first use in this function)
LOCKDOWN_E_PAIRING_DIALOG_RESPONSE_PENDING?

Created attachment 329280 [details] [review]
afc: Fix iOS 7 trust dialogue handling

There are new iOS 7 related error codes that we need to handle to catch
cases where a user action is required on the device.

Review of attachment 329280 [details] [review]:

Looks good, although I've just realized that you should also handle those error codes in g_vfs_backend_lockdownd_check.

(In reply to Ondrej Holy from comment #4)
> Review of attachment 329280 [details] [review] [review]:
> 
> Looks good, although I've just realized that you should also handle those
> error codes in g_vfs_backend_lockdownd_check.

I've done that in a separate patch in bug 763605.

Comment on attachment 329280 [details] [review]
afc: Fix iOS 7 trust dialogue handling

(In reply to Bastien Nocera from comment #5)
> (In reply to Ondrej Holy from comment #4)
> > Review of attachment 329280 [details] [review] [review] [review]:
> > 
> > Looks good, although I've just realized that you should also handle those
> > error codes in g_vfs_backend_lockdownd_check.
> 
> I've done that in a separate patch in bug 763605.

It is ok then...

Attachment 329280 [details] pushed as 409a172 - afc: Fix iOS 7 trust dialogue handling